Skip to content

Commit

Permalink
hw/arm/virt: Add PMU node for virt machine
Browse files Browse the repository at this point in the history
Add a virtual PMU device for virt machine while use PPI 7 for PMU
overflow interrupt number.

Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Message-id: 1465267577-1808-3-git-send-email-zhaoshenglong@huawei.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  • Loading branch information
shannonz88 authored and pm215 committed Jun 14, 2016
1 parent 5c0a381 commit 01fe6b6
Show file tree
Hide file tree
Showing 5 changed files with 91 additions and 0 deletions.
33 changes: 33 additions & 0 deletions hw/arm/virt.c
Expand Up @@ -436,6 +436,37 @@ static void fdt_add_gic_node(VirtBoardInfo *vbi, int type)
qemu_fdt_setprop_cell(vbi->fdt, "/intc", "phandle", vbi->gic_phandle);
}

static void fdt_add_pmu_nodes(const VirtBoardInfo *vbi, int gictype)
{
CPUState *cpu;
ARMCPU *armcpu;
uint32_t irqflags = GIC_FDT_IRQ_FLAGS_LEVEL_HI;

CPU_FOREACH(cpu) {
armcpu = ARM_CPU(cpu);
if (!armcpu->has_pmu ||
!kvm_arm_pmu_create(cpu, PPI(VIRTUAL_PMU_IRQ))) {
return;
}
}

if (gictype == 2) {
irqflags = deposit32(irqflags, GIC_FDT_IRQ_PPI_CPU_START,
GIC_FDT_IRQ_PPI_CPU_WIDTH,
(1 << vbi->smp_cpus) - 1);
}

armcpu = ARM_CPU(qemu_get_cpu(0));
qemu_fdt_add_subnode(vbi->fdt, "/pmu");
if (arm_feature(&armcpu->env, ARM_FEATURE_V8)) {
const char compat[] = "arm,armv8-pmuv3";
qemu_fdt_setprop(vbi->fdt, "/pmu", "compatible",
compat, sizeof(compat));
qemu_fdt_setprop_cells(vbi->fdt, "/pmu", "interrupts",
GIC_FDT_IRQ_TYPE_PPI, VIRTUAL_PMU_IRQ, irqflags);
}
}

static void create_v2m(VirtBoardInfo *vbi, qemu_irq *pic)
{
int i;
Expand Down Expand Up @@ -1259,6 +1290,8 @@ static void machvirt_init(MachineState *machine)

create_gic(vbi, pic, gic_version, vms->secure);

fdt_add_pmu_nodes(vbi, gic_version);

create_uart(vbi, pic, VIRT_UART, sysmem, serial_hds[0]);

if (vms->secure) {
Expand Down
4 changes: 4 additions & 0 deletions include/hw/arm/virt.h
Expand Up @@ -41,6 +41,10 @@
#define ARCH_TIMER_NS_EL1_IRQ 14
#define ARCH_TIMER_NS_EL2_IRQ 10

#define VIRTUAL_PMU_IRQ 7

#define PPI(irq) ((irq) + 16)

enum {
VIRT_FLASH,
VIRT_MEM,
Expand Down
6 changes: 6 additions & 0 deletions target-arm/kvm32.c
Expand Up @@ -522,3 +522,9 @@ bool kvm_arm_hw_debug_active(CPUState *cs)
{
return false;
}

int kvm_arm_pmu_create(CPUState *cs, int irq)
{
qemu_log_mask(LOG_UNIMP, "%s: not implemented\n", __func__);
return 0;
}
41 changes: 41 additions & 0 deletions target-arm/kvm64.c
Expand Up @@ -382,6 +382,47 @@ static CPUWatchpoint *find_hw_watchpoint(CPUState *cpu, target_ulong addr)
return NULL;
}

static bool kvm_arm_pmu_support_ctrl(CPUState *cs, struct kvm_device_attr *attr)
{
return kvm_vcpu_ioctl(cs, KVM_HAS_DEVICE_ATTR, attr) == 0;
}

int kvm_arm_pmu_create(CPUState *cs, int irq)
{
int err;

struct kvm_device_attr attr = {
.group = KVM_ARM_VCPU_PMU_V3_CTRL,
.addr = (intptr_t)&irq,
.attr = KVM_ARM_VCPU_PMU_V3_IRQ,
.flags = 0,
};

if (!kvm_arm_pmu_support_ctrl(cs, &attr)) {
return 0;
}

err = kvm_vcpu_ioctl(cs, KVM_SET_DEVICE_ATTR, &attr);
if (err < 0) {
fprintf(stderr, "KVM_SET_DEVICE_ATTR failed: %s\n",
strerror(-err));
abort();
}

attr.group = KVM_ARM_VCPU_PMU_V3_CTRL;
attr.attr = KVM_ARM_VCPU_PMU_V3_INIT;
attr.addr = 0;
attr.flags = 0;

err = kvm_vcpu_ioctl(cs, KVM_SET_DEVICE_ATTR, &attr);
if (err < 0) {
fprintf(stderr, "KVM_SET_DEVICE_ATTR failed: %s\n",
strerror(-err));
abort();
}

return 1;
}

static inline void set_feature(uint64_t *features, int feature)
{
Expand Down
7 changes: 7 additions & 0 deletions target-arm/kvm_arm.h
Expand Up @@ -194,13 +194,20 @@ int kvm_arm_sync_mpstate_to_qemu(ARMCPU *cpu);

int kvm_arm_vgic_probe(void);

int kvm_arm_pmu_create(CPUState *cs, int irq);

#else

static inline int kvm_arm_vgic_probe(void)
{
return 0;
}

static inline int kvm_arm_pmu_create(CPUState *cs, int irq)
{
return 0;
}

#endif

static inline const char *gic_class_name(void)
Expand Down

0 comments on commit 01fe6b6

Please sign in to comment.