Skip to content

Commit

Permalink
vhost: Rename last_index to vq_index_end
Browse files Browse the repository at this point in the history
The doc of this field pointed out that last_index is the last vq index.
This is misleading, since it's actually one past the end of the vqs.

Renaming and modifying comment.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20211104085625.2054959-2-eperezma@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
  • Loading branch information
eugpermar authored and mstsirkin committed Nov 11, 2021
1 parent b66cecb commit 245cf2c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions hw/net/vhost_net.c
Original file line number Diff line number Diff line change
Expand Up @@ -232,10 +232,10 @@ struct vhost_net *vhost_net_init(VhostNetOptions *options)
}

static void vhost_net_set_vq_index(struct vhost_net *net, int vq_index,
int last_index)
int vq_index_end)
{
net->dev.vq_index = vq_index;
net->dev.last_index = last_index;
net->dev.vq_index_end = vq_index_end;
}

static int vhost_net_start_one(struct vhost_net *net,
Expand Down
2 changes: 1 addition & 1 deletion hw/virtio/vhost-vdpa.c
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ static int vhost_vdpa_dev_start(struct vhost_dev *dev, bool started)
vhost_vdpa_host_notifiers_uninit(dev, dev->nvqs);
}

if (dev->vq_index + dev->nvqs != dev->last_index) {
if (dev->vq_index + dev->nvqs != dev->vq_index_end) {
return 0;
}

Expand Down
4 changes: 2 additions & 2 deletions include/hw/virtio/vhost.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ struct vhost_dev {
unsigned int nvqs;
/* the first virtqueue which would be used by this vhost dev */
int vq_index;
/* the last vq index for the virtio device (not vhost) */
int last_index;
/* one past the last vq index for the virtio device (not vhost) */
int vq_index_end;
/* if non-zero, minimum required value for max_queues */
int num_queues;
uint64_t features;
Expand Down

0 comments on commit 245cf2c

Please sign in to comment.