Skip to content

Commit

Permalink
qemu-img: assert block_job_get() does not return NULL in img_commit()
Browse files Browse the repository at this point in the history
Although the function block_job_get() can return NULL, it would be a
serious bug if it did so (because the job yields before executing anything
(if it started successfully); but otherwise, commit_active_start() would
have returned an error).  However, as a precaution, before dereferencing
the 'job' pointer in img_commit() assert it is not NULL.

Signed-off-by: Liam Merwick <Liam.Merwick@oracle.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 1541453919-25973-4-git-send-email-Liam.Merwick@oracle.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
  • Loading branch information
merwick authored and XanClic committed Nov 12, 2018
1 parent 602414d commit 2e2db26
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions qemu-img.c
Original file line number Diff line number Diff line change
Expand Up @@ -1029,6 +1029,7 @@ static int img_commit(int argc, char **argv)
}

job = block_job_get("commit");
assert(job);
run_block_job(job, &local_err);
if (local_err) {
goto unref_backing;
Expand Down

0 comments on commit 2e2db26

Please sign in to comment.