Skip to content

Commit

Permalink
tests/device-plug: Add memory unplug request test for spapr
Browse files Browse the repository at this point in the history
We can easily test this, just like PCI. On x86 ACPI, we need guest
interaction to make it work, so it is not that easy to test. We might
add tests for that later on.

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190218092202.26683-7-david@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
  • Loading branch information
davidhildenbrand authored and dgibson committed Feb 25, 2019
1 parent c76480e commit 3688070
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions tests/device-plug-test.c
Expand Up @@ -116,6 +116,22 @@ static void test_spapr_cpu_unplug_request(void)
qtest_quit(qtest);
}

static void test_spapr_memory_unplug_request(void)
{
QTestState *qtest;

qtest = qtest_initf("-m 256M,slots=1,maxmem=768M "
"-object memory-backend-ram,id=mem0,size=512M "
"-device pc-dimm,id=dev0,memdev=mem0");

/* similar to test_pci_unplug_request */
device_del_request(qtest, "dev0");
system_reset(qtest);
wait_device_deleted_event(qtest, "dev0");

qtest_quit(qtest);
}

int main(int argc, char **argv)
{
const char *arch = qtest_get_arch();
Expand All @@ -138,6 +154,8 @@ int main(int argc, char **argv)
if (!strcmp(arch, "ppc64")) {
qtest_add_func("/device-plug/spapr-cpu-unplug-request",
test_spapr_cpu_unplug_request);
qtest_add_func("/device-plug/spapr-memory-unplug-request",
test_spapr_memory_unplug_request);
}

return g_test_run();
Expand Down

0 comments on commit 3688070

Please sign in to comment.