Skip to content

Commit

Permalink
accel/kvm: Make kvm_dirty_ring_reaper_init() void
Browse files Browse the repository at this point in the history
The returned value was always zero and had no meaning.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-id: 20230727073134.134102-7-akihiko.odaki@daynix.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
  • Loading branch information
akihikodaki authored and pm215 committed Aug 22, 2023
1 parent 4625742 commit 43a5e37
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions accel/kvm/kvm-all.c
Original file line number Diff line number Diff line change
Expand Up @@ -1454,15 +1454,13 @@ static void *kvm_dirty_ring_reaper_thread(void *data)
return NULL;
}

static int kvm_dirty_ring_reaper_init(KVMState *s)
static void kvm_dirty_ring_reaper_init(KVMState *s)
{
struct KVMDirtyRingReaper *r = &s->reaper;

qemu_thread_create(&r->reaper_thr, "kvm-reaper",
kvm_dirty_ring_reaper_thread,
s, QEMU_THREAD_JOINABLE);

return 0;
}

static int kvm_dirty_ring_init(KVMState *s)
Expand Down Expand Up @@ -2744,10 +2742,7 @@ static int kvm_init(MachineState *ms)
}

if (s->kvm_dirty_ring_size) {
ret = kvm_dirty_ring_reaper_init(s);
if (ret) {
goto err;
}
kvm_dirty_ring_reaper_init(s);
}

if (kvm_check_extension(kvm_state, KVM_CAP_BINARY_STATS_FD)) {
Expand Down

0 comments on commit 43a5e37

Please sign in to comment.