Skip to content

Commit

Permalink
tests/qtest/libqos/e1000e: Use E1000_STATUS_ASDV_1000
Browse files Browse the repository at this point in the history
Nemonics E1000_STATUS_LAN_INIT_DONE and E1000_STATUS_ASDV_1000 have
the same value, and E1000_STATUS_ASDV_1000 should be used here because
E1000_STATUS_ASDV_1000 represents the auto-detected speed tested here
while E1000_STATUS_LAN_INIT_DONE is a value used for a different purpose
with a variant of e1000e family different from the one implemented in
QEMU.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Message-Id: <20221103083425.100590-1-akihiko.odaki@daynix.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
  • Loading branch information
akihikodaki authored and huth committed Nov 6, 2022
1 parent dfa644b commit 5ebafa1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/qtest/libqos/e1000e.c
Expand Up @@ -130,8 +130,8 @@ static void e1000e_pci_start_hw(QOSGraphObject *obj)

/* Check the device status - link and speed */
val = e1000e_macreg_read(&d->e1000e, E1000_STATUS);
g_assert_cmphex(val & (E1000_STATUS_LU | E1000_STATUS_LAN_INIT_DONE),
==, E1000_STATUS_LU | E1000_STATUS_LAN_INIT_DONE);
g_assert_cmphex(val & (E1000_STATUS_LU | E1000_STATUS_ASDV_1000),
==, E1000_STATUS_LU | E1000_STATUS_ASDV_1000);

/* Initialize TX/RX logic */
e1000e_macreg_write(&d->e1000e, E1000_RCTL, 0);
Expand Down

0 comments on commit 5ebafa1

Please sign in to comment.