Skip to content

Commit

Permalink
hw/mips/malta: use pci_init_nic_devices()
Browse files Browse the repository at this point in the history
The Malta board setup code would previously place the first NIC into PCI
slot 11 if was a PCNet card, and the rest (including the first if it was
anything other than a PCNet card) would be dynamically assigned.

Now it will place any PCNet NIC into slot 11, and then anything else will
be dynamically assigned.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Thomas Huth <thuth@redhat.com>
  • Loading branch information
dwmw2 committed Feb 1, 2024
1 parent aff3ec4 commit 6065398
Showing 1 changed file with 3 additions and 12 deletions.
15 changes: 3 additions & 12 deletions hw/mips/malta.c
Original file line number Diff line number Diff line change
Expand Up @@ -612,18 +612,9 @@ static MaltaFPGAState *malta_fpga_init(MemoryRegion *address_space,
/* Network support */
static void network_init(PCIBus *pci_bus)
{
int i;

for (i = 0; i < nb_nics; i++) {
NICInfo *nd = &nd_table[i];
const char *default_devaddr = NULL;

if (i == 0 && (!nd->model || strcmp(nd->model, "pcnet") == 0))
/* The malta board has a PCNet card using PCI SLOT 11 */
default_devaddr = "0b";

pci_nic_init_nofail(nd, pci_bus, "pcnet", default_devaddr);
}
/* The malta board has a PCNet card using PCI SLOT 11 */
pci_init_nic_in_slot(pci_bus, "pcnet", NULL, "0b");
pci_init_nic_devices(pci_bus, "pcnet");
}

static void bl_setup_gt64120_jump_kernel(void **p, uint64_t run_addr,
Expand Down

0 comments on commit 6065398

Please sign in to comment.