Skip to content

Commit

Permalink
usb: Fix incorrect default DMA offset.
Browse files Browse the repository at this point in the history
The default DMA offset is set to 3. When the property is not set by
the consumer, the default causes DMA access to be shifted by 3
bytes. In PXA, this results in incorrect DMA access, leading to error
notification in the USB controller driver. A better default would be
0, so that there is no offset, when the consumer does not specify one.

Signed-off-by: Vijay Kumar B. <vijaykumar@zilogic.com>
Reviewed-by: Deepak S. <deepak@zilogic.com>
Message-id: 1475060958-7760-1-git-send-email-vijaykumar@zilogic.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
  • Loading branch information
bravegnu authored and kraxel committed Oct 12, 2016
1 parent 0136464 commit 6998b6c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hw/usb/hcd-ohci.c
Original file line number Diff line number Diff line change
Expand Up @@ -2139,7 +2139,7 @@ static const TypeInfo ohci_pci_info = {

static Property ohci_sysbus_properties[] = {
DEFINE_PROP_UINT32("num-ports", OHCISysBusState, num_ports, 3),
DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 3),
DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 0),
DEFINE_PROP_END_OF_LIST(),
};

Expand Down

0 comments on commit 6998b6c

Please sign in to comment.