Skip to content

Commit

Permalink
gdbstub: Introduce gdb_handle_query_supported_user()
Browse files Browse the repository at this point in the history
The upcoming follow-fork-mode child support requires advertising the
fork-events feature, which is user-specific. Introduce a user-specific
hook for this.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20240219141628.246823-9-iii@linux.ibm.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240305121005.3528075-10-alex.bennee@linaro.org>
  • Loading branch information
iii-i authored and stsquad committed Mar 6, 2024
1 parent 6604b05 commit 6d92311
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
12 changes: 9 additions & 3 deletions gdbstub/gdbstub.c
Original file line number Diff line number Diff line change
Expand Up @@ -1655,9 +1655,15 @@ static void handle_query_supported(GArray *params, void *user_ctx)
g_string_append(gdbserver_state.str_buf, ";qXfer:exec-file:read+");
#endif

if (params->len &&
strstr(get_param(params, 0)->data, "multiprocess+")) {
gdbserver_state.multiprocess = true;
if (params->len) {
const char *gdb_supported = get_param(params, 0)->data;

if (strstr(gdb_supported, "multiprocess+")) {
gdbserver_state.multiprocess = true;
}
#if defined(CONFIG_USER_ONLY)
gdb_handle_query_supported_user(gdb_supported);
#endif
}

g_string_append(gdbserver_state.str_buf, ";vContSupported+;multiprocess+");
Expand Down
1 change: 1 addition & 0 deletions gdbstub/internals.h
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ void gdb_handle_v_file_pread(GArray *params, void *user_ctx); /* user */
void gdb_handle_v_file_readlink(GArray *params, void *user_ctx); /* user */
void gdb_handle_query_xfer_exec_file(GArray *params, void *user_ctx); /* user */
void gdb_handle_set_catch_syscalls(GArray *params, void *user_ctx); /* user */
void gdb_handle_query_supported_user(const char *gdb_supported); /* user */

void gdb_handle_query_attached(GArray *params, void *user_ctx); /* both */

Expand Down
4 changes: 4 additions & 0 deletions gdbstub/user.c
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,10 @@ void gdbserver_fork_end(CPUState *cpu, pid_t pid)
disable_gdbstub(cpu);
}

void gdb_handle_query_supported_user(const char *gdb_supported)
{
}

/*
* Execution state helpers
*/
Expand Down

0 comments on commit 6d92311

Please sign in to comment.