Skip to content

Commit

Permalink
cs4231a: QOM'ify some more
Browse files Browse the repository at this point in the history
Introduce type constant and cast macro.
Replace reset hook with DeviceClass::reset callback.

Signed-off-by: Andreas Färber <afaerber@suse.de>
  • Loading branch information
afaerber committed Jun 6, 2013
1 parent 11c7549 commit a3dcca5
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions hw/audio/cs4231a.c
Expand Up @@ -56,6 +56,9 @@ static struct {
#define CS_REGS 16
#define CS_DREGS 32

#define TYPE_CS4231A "cs4231a"
#define CS4231A(obj) OBJECT_CHECK (CSState, (obj), TYPE_CS4231A)

typedef struct CSState {
ISADevice dev;
QEMUSoundCard card;
Expand Down Expand Up @@ -208,9 +211,9 @@ static int16_t ALawDecompressTable[256] =
944, 912, 1008, 976, 816, 784, 880, 848
};

static void cs_reset (void *opaque)
static void cs4231a_reset (DeviceState *dev)
{
CSState *s = opaque;
CSState *s = CS4231A (dev);

s->regs[Index_Address] = 0x40;
s->regs[Index_Data] = 0x00;
Expand Down Expand Up @@ -643,7 +646,7 @@ static const MemoryRegionOps cs_ioport_ops = {

static int cs4231a_initfn (ISADevice *dev)
{
CSState *s = DO_UPCAST (CSState, dev, dev);
CSState *s = CS4231A (dev);

isa_init_irq (dev, &s->pic, s->irq);

Expand All @@ -652,16 +655,13 @@ static int cs4231a_initfn (ISADevice *dev)

DMA_register_channel (s->dma, cs_dma_read, s);

qemu_register_reset (cs_reset, s);
cs_reset (s);

AUD_register_card ("cs4231a", &s->card);
return 0;
}

static int cs4231a_init (ISABus *bus)
{
isa_create_simple (bus, "cs4231a");
isa_create_simple (bus, TYPE_CS4231A);
return 0;
}

Expand All @@ -677,13 +677,14 @@ static void cs4231a_class_initfn (ObjectClass *klass, void *data)
DeviceClass *dc = DEVICE_CLASS (klass);
ISADeviceClass *ic = ISA_DEVICE_CLASS (klass);
ic->init = cs4231a_initfn;
dc->reset = cs4231a_reset;
dc->desc = "Crystal Semiconductor CS4231A";
dc->vmsd = &vmstate_cs4231a;
dc->props = cs4231a_properties;
}

static const TypeInfo cs4231a_info = {
.name = "cs4231a",
.name = TYPE_CS4231A,
.parent = TYPE_ISA_DEVICE,
.instance_size = sizeof (CSState),
.class_init = cs4231a_class_initfn,
Expand Down

0 comments on commit a3dcca5

Please sign in to comment.