Skip to content

Commit

Permalink
tests/avocado: remove flaky test marking for test_sbsaref_edk2_firmware
Browse files Browse the repository at this point in the history
After testing locally I decided to revert a575484 (tests/avocado: Disable the
test_sbsaref_edk2_firmware by default) as the test seems pretty
stable:

   env QEMU_TEST_FLAKY_TESTS=1 retry.py -n 50 -c -- \
     ./tests/venv/bin/avocado run \
     ./tests/avocado/machine_aarch64_sbsaref.py:Aarch64SbsarefMachine.test_sbsaref_edk2_firmware

yields:

  Results summary:
  0: 50 times (100.00%), avg time 2.064 (0.04 varience/0.19 deviation)
  Ran command 50 times, 50 passes

Maybe f0ec14c (tests/avocado: Fix console data loss) has made it
more reliable?

Cc: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231009164104.369749-3-alex.bennee@linaro.org>
  • Loading branch information
stsquad committed Oct 11, 2023
1 parent 404b784 commit a956ea5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tests/avocado/machine_aarch64_sbsaref.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ def fetch_firmware(self):
"sbsa-ref",
)

@skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'Test is not reliable')
def test_sbsaref_edk2_firmware(self):
"""
:avocado: tags=cpu:cortex-a57
Expand Down

0 comments on commit a956ea5

Please sign in to comment.