Skip to content

Commit

Permalink
disas/sh4: Add missing fallthrough annotations
Browse files Browse the repository at this point in the history
Add fallthrough annotations to be able to compile the code without
warnings with -Wimplicit-fallthrough. Looking at the code, it seems
like the fallthrough is indeed intended here, so the comments should
be appropriate.

Message-Id: <20200630055953.9309-1-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
  • Loading branch information
huth committed Jul 13, 2020
1 parent 7aa12aa commit ccb2370
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions disas/sh4.c
Original file line number Diff line number Diff line change
Expand Up @@ -1963,6 +1963,7 @@ print_insn_sh (bfd_vma memaddr, struct disassemble_info *info)
fprintf_fn (stream, "xd%d", rn & ~1);
break;
}
/* fallthrough */
case D_REG_N:
fprintf_fn (stream, "dr%d", rn);
break;
Expand All @@ -1972,6 +1973,7 @@ print_insn_sh (bfd_vma memaddr, struct disassemble_info *info)
fprintf_fn (stream, "xd%d", rm & ~1);
break;
}
/* fallthrough */
case D_REG_M:
fprintf_fn (stream, "dr%d", rm);
break;
Expand Down

0 comments on commit ccb2370

Please sign in to comment.