Skip to content

Commit

Permalink
target/riscv: pmu: Rename the counters extension to pmu
Browse files Browse the repository at this point in the history
The PMU counters are supported via cpu config "Counters" which doesn't
indicate the correct purpose of those counters.

Rename the config property to pmu to indicate that these counters
are performance monitoring counters. This aligns with cpu options for
ARM architecture as well.

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Atish Patra <atish.patra@wdc.com>
Signed-off-by: Atish Patra <atishp@rivosinc.com>
Message-Id: <20220620231603.2547260-4-atishp@rivosinc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
  • Loading branch information
atishp04 authored and alistair23 committed Jul 3, 2022
1 parent a5a92fd commit d3be129
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions target/riscv/cpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,7 @@ static void riscv_cpu_init(Object *obj)
{
RISCVCPU *cpu = RISCV_CPU(obj);

cpu->cfg.ext_counters = true;
cpu->cfg.ext_pmu = true;
cpu->cfg.ext_ifencei = true;
cpu->cfg.ext_icsr = true;
cpu->cfg.mmu = true;
Expand Down Expand Up @@ -879,7 +879,7 @@ static Property riscv_cpu_extensions[] = {
DEFINE_PROP_BOOL("u", RISCVCPU, cfg.ext_u, true),
DEFINE_PROP_BOOL("v", RISCVCPU, cfg.ext_v, false),
DEFINE_PROP_BOOL("h", RISCVCPU, cfg.ext_h, true),
DEFINE_PROP_BOOL("Counters", RISCVCPU, cfg.ext_counters, true),
DEFINE_PROP_BOOL("pmu", RISCVCPU, cfg.ext_pmu, true),
DEFINE_PROP_BOOL("Zifencei", RISCVCPU, cfg.ext_ifencei, true),
DEFINE_PROP_BOOL("Zicsr", RISCVCPU, cfg.ext_icsr, true),
DEFINE_PROP_BOOL("Zfh", RISCVCPU, cfg.ext_zfh, false),
Expand Down
2 changes: 1 addition & 1 deletion target/riscv/cpu.h
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ struct RISCVCPUConfig {
bool ext_zksed;
bool ext_zksh;
bool ext_zkt;
bool ext_counters;
bool ext_pmu;
bool ext_ifencei;
bool ext_icsr;
bool ext_svinval;
Expand Down
4 changes: 2 additions & 2 deletions target/riscv/csr.c
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ static RISCVException ctr(CPURISCVState *env, int csrno)
RISCVCPU *cpu = RISCV_CPU(cs);
int ctr_index;

if (!cpu->cfg.ext_counters) {
/* The Counters extensions is not enabled */
if (!cpu->cfg.ext_pmu) {
/* The PMU extension is not enabled */
return RISCV_EXCP_ILLEGAL_INST;
}

Expand Down

0 comments on commit d3be129

Please sign in to comment.