Skip to content

Commit

Permalink
tap-win32: Remove unnecessary stubs
Browse files Browse the repository at this point in the history
Some of them are only necessary for POSIX systems. The others are
assigned to function pointers in NetClientInfo that can actually be
NULL.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
  • Loading branch information
akihikodaki authored and jasowang committed Mar 29, 2024
1 parent 89a8de3 commit decfde6
Showing 1 changed file with 0 additions and 54 deletions.
54 changes: 0 additions & 54 deletions net/tap-win32.c
Original file line number Diff line number Diff line change
Expand Up @@ -707,70 +707,16 @@ static void tap_win32_send(void *opaque)
}
}

static bool tap_has_ufo(NetClientState *nc)
{
return false;
}

static bool tap_has_vnet_hdr(NetClientState *nc)
{
return false;
}

int tap_probe_vnet_hdr_len(int fd, int len)
{
return 0;
}

void tap_fd_set_vnet_hdr_len(int fd, int len)
{
}

int tap_fd_set_vnet_le(int fd, int is_le)
{
return -EINVAL;
}

int tap_fd_set_vnet_be(int fd, int is_be)
{
return -EINVAL;
}

static void tap_using_vnet_hdr(NetClientState *nc, bool using_vnet_hdr)
{
}

static void tap_set_offload(NetClientState *nc, int csum, int tso4,
int tso6, int ecn, int ufo, int uso4, int uso6)
{
}

struct vhost_net *tap_get_vhost_net(NetClientState *nc)
{
return NULL;
}

static bool tap_has_vnet_hdr_len(NetClientState *nc, int len)
{
return false;
}

static void tap_set_vnet_hdr_len(NetClientState *nc, int len)
{
abort();
}

static NetClientInfo net_tap_win32_info = {
.type = NET_CLIENT_DRIVER_TAP,
.size = sizeof(TAPState),
.receive = tap_receive,
.cleanup = tap_cleanup,
.has_ufo = tap_has_ufo,
.has_vnet_hdr = tap_has_vnet_hdr,
.has_vnet_hdr_len = tap_has_vnet_hdr_len,
.using_vnet_hdr = tap_using_vnet_hdr,
.set_offload = tap_set_offload,
.set_vnet_hdr_len = tap_set_vnet_hdr_len,
};

static int tap_win32_init(NetClientState *peer, const char *model,
Expand Down

0 comments on commit decfde6

Please sign in to comment.