Skip to content

Commit

Permalink
hw/smbios: Fix OEM strings table option validation
Browse files Browse the repository at this point in the history
qemu_smbios_type11_opts did not have the list terminator and that
resulted in out-of-bound memory access. It also needs to have an element
for the type option.

Cc: qemu-stable@nongnu.org
Fixes: 2d6dcbf ("smbios: support setting OEM strings table")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Message-Id: <20240129-smbios-v2-1-9ee6fede0d10@daynix.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
  • Loading branch information
akihikodaki authored and mstsirkin committed Feb 14, 2024
1 parent 574b64a commit e8ddec5
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions hw/smbios/smbios.c
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,11 @@ static const QemuOptDesc qemu_smbios_type8_opts[] = {
};

static const QemuOptDesc qemu_smbios_type11_opts[] = {
{
.name = "type",
.type = QEMU_OPT_NUMBER,
.help = "SMBIOS element type",
},
{
.name = "value",
.type = QEMU_OPT_STRING,
Expand All @@ -385,6 +390,7 @@ static const QemuOptDesc qemu_smbios_type11_opts[] = {
.type = QEMU_OPT_STRING,
.help = "OEM string data from file",
},
{ /* end of list */ }
};

static const QemuOptDesc qemu_smbios_type17_opts[] = {
Expand Down

0 comments on commit e8ddec5

Please sign in to comment.