Skip to content

Commit

Permalink
target/s390x: don't use ld_code2 to probe next pc
Browse files Browse the repository at this point in the history
This isn't an translator picking up an instruction so we shouldn't use
the translator_lduw function which has side effects for plugins.

Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20221027183637.2772968-24-alex.bennee@linaro.org>
  • Loading branch information
stsquad committed Oct 31, 2022
1 parent 839866f commit efe7c4f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion target/s390x/tcg/translate.c
Expand Up @@ -6612,7 +6612,7 @@ static void s390x_tr_insn_start(DisasContextBase *dcbase, CPUState *cs)
static target_ulong get_next_pc(CPUS390XState *env, DisasContext *s,
uint64_t pc)
{
uint64_t insn = ld_code2(env, s, pc);
uint64_t insn = cpu_lduw_code(env, pc);

return pc + get_ilen((insn >> 8) & 0xff);
}
Expand Down

0 comments on commit efe7c4f

Please sign in to comment.