Skip to content

Commit

Permalink
xics-kvm: Fix reset function
Browse files Browse the repository at this point in the history
Currently interrupt priorities are set to 0 (highest) at the very
beginning of the guest execution which is not correct and makes the guest
produce random interrupt error messages such as:
"Interrupt 0x1001 (real) is invalid, disabling it".
This also prevents interrupt states from correct migration.

This initializes priority to 0xFF as the emulated XICS does.

Suggested-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Andreas Färber <afaerber@suse.de>
  • Loading branch information
aik authored and afaerber committed Mar 13, 2014
1 parent 8f3babb commit fb0e843
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion hw/intc/xics_kvm.c
Expand Up @@ -269,7 +269,16 @@ static void ics_kvm_set_irq(void *opaque, int srcno, int val)

static void ics_kvm_reset(DeviceState *dev)
{
ics_set_kvm_state(ICS(dev), 1);
ICSState *ics = ICS(dev);
int i;

memset(ics->irqs, 0, sizeof(ICSIRQState) * ics->nr_irqs);
for (i = 0; i < ics->nr_irqs; i++) {
ics->irqs[i].priority = 0xff;
ics->irqs[i].saved_priority = 0xff;
}

ics_set_kvm_state(ics, 1);
}

static void ics_kvm_realize(DeviceState *dev, Error **errp)
Expand Down

0 comments on commit fb0e843

Please sign in to comment.