Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for point cloud expressions to Processing expression parameter (Request in QGIS) #8233

Closed
qgis-bot opened this issue May 2, 2023 · 1 comment · Fixed by #8457

Comments

@qgis-bot
Copy link
Collaborator

qgis-bot commented May 2, 2023

Request for documentation

From pull request qgis/QGIS#52730
Author: @alexbruy
QGIS version: 3.32

Add support for point cloud expressions to Processing expression parameter

PR Description:

Description

With addition of filtering capabilities to point cloud algorithms, we need a userfriedly way to build point cloud expressions similarly to the QGIS native expressions.

To make it possible this pull-request adds a Type enum to QgsProcessingParameterExpression parameter with two options Qgis and PointCloud. If parameter has a PointCloud type, it will use new widget wrapper with GUI point cloud expression builder.
2023-04-17-091207_1366x768_scrot
To maintain backward compatibility, by default expression parameter uses Qgis expression type.

The QgsPointCloudExpression class was extented with the new method to convert QGIS point cloud expressions to PDAL expressions.

All PDAL algorithms using expression filter were updated to use expression parameter instead of strings.

Commits tagged with [need-docs] or [FEATURE]

@DelazJ
Copy link
Collaborator

DelazJ commented Sep 1, 2023

The QgsPointCloudExpression class was extented with the new method to convert QGIS point cloud expressions to PDAL expressions.

@alexbruy What does this mean? When does one would use this feature? It does not mean that in QGIS (e.g. provider filter dialog or expression from PDAL alg) we can use PDAL-like expressions, right? As far as I could see, some of the examples in the PDAL docs do not pass in QGIS. Can you clarify, please? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants