Add support for point cloud expressions to Processing expression parameter #52730
Conversation
alexbruy
added
Feature
Processing
|
@alexbruy A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
python/core/auto_generated/processing/qgsprocessingparameters.sip.in
Outdated
Show resolved
Hide resolved
| * | ||
| * \since QGIS 3.32 | ||
| */ | ||
| QString asPdalExpression() const; |
There was a problem hiding this comment.
I think this needs some bool& ok SIP_OUT, QString& error SIP_OUT arguments so that callers can get feedback if an expression can't be converted to PDAL format
There was a problem hiding this comment.
Not sure about it. Conversion is done similar to how the dump() method works, with occasional substring replacement (e.g. "and" is replaced with "&&").
| void QgsProcessingPointCloudExpressionLineEdit::editExpression() | ||
| { | ||
| const QString currentExpression = expression(); | ||
| QgsProcessingPointCloudExpressionDialog dlg( mLayer ); |
There was a problem hiding this comment.
it would be SUPER nice to make this open as a QgsPanelWidget. Then we could avoid an unwanted modal dialog blocking things.
There was a problem hiding this comment.
Would you mind if I do it in a follow up pull-request?
distinguish between native QGIS expressions and point cloud filter expressions
parameter definition widget
|
@alexbruy |
zacharlie
added
the
Changelog
|
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
zacharlie
added
ChangelogHarvested
Description
With addition of filtering capabilities to point cloud algorithms, we need a userfriedly way to build point cloud expressions similarly to the QGIS native expressions.
To make it possible this pull-request adds a
Typeenum toQgsProcessingParameterExpressionparameter with two optionsQgisandPointCloud. If parameter has aPointCloudtype, it will use new widget wrapper with GUI point cloud expression builder.To maintain backward compatibility, by default expression parameter uses
Qgisexpression type.The
QgsPointCloudExpressionclass was extented with the new method to convert QGIS point cloud expressions to PDAL expressions.All PDAL algorithms using expression filter were updated to use expression parameter instead of strings.