Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are all new features in 2.14 reported in the issues report? #826

Closed
DelazJ opened this issue Feb 14, 2016 · 16 comments
Closed

Are all new features in 2.14 reported in the issues report? #826

DelazJ opened this issue Feb 14, 2016 · 16 comments
Labels
Milestone

Comments

@DelazJ
Copy link
Collaborator

DelazJ commented Feb 14, 2016

Looking for an issue report in QGIS Redmine, I found out this commit (qgis/QGIS@3c33177) which is a new feature in 2.14 but not automagically reported in the Doc issues list.
Note tha instead of [FEATURE], it's tagged [Feature], so I wonder if it's the only one we didn't notice or if there are others. And more important, if some scripts guru can retrieve all the missing ones.

@DelazJ DelazJ added this to the QGIS 2.14 milestone Feb 14, 2016
@yjacolin
Copy link
Member

something like git log --since=20/02/2015 --grep='Feature" could do the trick.

@yjacolin
Copy link
Member

We need to check with the script developer to not be case sensitive.

@rduivenvoorde
Copy link
Contributor

code is here:
https://github.com/qgis/QGIS-Sysadmin/blob/master/webhooks/github_feature_tracker.cgi
script runs on qgis server
will have a look at it later

@yjacolin
Copy link
Member

https://github.com/qgis/QGIS-Sysadmin/blob/master/webhooks/github_feature_tracker.cgi#L423
Something like this could do the work?
'[feature]' in msg.tower()

@rduivenvoorde
Copy link
Contributor

tower? is that Python?
'[feature]' in msg.upper() would work I think
But have to do it both in github and on server, will have to take some time to do that

@yjacolin
Copy link
Member

this is a typo, ie read lower() :)

PR ready to go on my side :)

@nyalldawson
Copy link
Contributor

any chance you could also add another keyword? [needs-docs]?

@yjacolin
Copy link
Member

Does the [feature] tags already means that we need docs? What could be the difference for you?

@rduivenvoorde
Copy link
Contributor

@nyalldawson well, that actually IS what we mean when we do [FEATURE]? Or do you want to be able to add it to excisting features?
Happy to add that off course...
Is there some consensus on labels syntax? Would be good to have them all like uppercase and short (or lowercase and short...) What about [NEED_DOCS] or [DOCS] in short?

@nyalldawson
Copy link
Contributor

I'm thinking for non-feature changes. Eg if a dialog is reworked.

A good example is qgis/QGIS@6453907, qgis/QGIS@ddbdcf8,
and qgis/QGIS@dfdcec8

They aren't new features, but require documentation updates

@dassau
Copy link
Member

dassau commented Feb 15, 2016

Hi,

i think that the ManualTask Wiki page is uptodate. I used a "git log
--since=20/02/2015 --grep='FEATURE'" for that...

http://hub.qgis.org/wiki/17/ManualTasks#Updates-210-214-User-Guide

Otto

Am Mon, 15 Feb 2016 00:19:53 -0800
schrieb Jacolin notifications@github.com:

this is a typo, ie read lower() :)

PR ready to go on my side :)


Reply to this email directly or view it on GitHub:
#826 (comment)

@rduivenvoorde
Copy link
Contributor

Ok, good to use that list now to check, and fix/update script for future, because I think working with features is easier to chop the work in pieces, and keep working on docs while developing?

@DelazJ
Copy link
Collaborator Author

DelazJ commented Feb 15, 2016

@dassau I cant' find the feature reported above (qgis/QGIS@3c33177) in the Wiki, meaning that not all features are there either.
@rduivenvoorde which list do u talk about: the Wiki or Github? if both list have been scripted using 'FEATURE' as argument, we should have the same list, no?
I personally prefer GitHub given that issue status is real-time updated (what's not the case for the wiki)

@rduivenvoorde
Copy link
Contributor

@DelazJ I mean the list @dassau created with his grep. Indeed this should have the same list. But there have been some bumps in the beginning, and we could have missed some with the github issue script there.

I prefer github list too, but the grep list is very easy to create and be used to (double) check.

We can always miss something anyway, but if we do a 'needdocs'-like tag too, we can always fix that :-)

@DelazJ
Copy link
Collaborator Author

DelazJ commented Feb 15, 2016

@rduivenvoorde:

I prefer github list too, but the grep list is very easy to create and be used to (double) check.

So the wiki list needs update

We can always miss something anyway, but if we do a 'needdocs'-like tag too, we can always fix that :-)

+1

@yjacolin
Copy link
Member

Close this issue as the answer's question is: yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants