Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some expression functions #1824

Merged
merged 2 commits into from
Apr 26, 2017
Merged

Add some expression functions #1824

merged 2 commits into from
Apr 26, 2017

Conversation

DelazJ
Copy link
Collaborator

@DelazJ DelazJ commented Apr 14, 2017

As usual the first commit (@fd50093) is compatible with 2.18
I let some comments because of missing description in the application (and reported the bug on hub)
Fixes #1723, Fixes #1715, Fixes #1649, Fixes #1617, Fixes #1616, Fixes #1615, Fixes #1540, Fixes #1539, Fixes #1521, Fixes #1514, Fixes #1509, Fixes #1486, Fixes #1479, Fixes #1476, Fixes #1475, Fixes #1472, Fixes #1379, Fixes #1348, Fixes #1304

@DelazJ
Copy link
Collaborator Author

DelazJ commented Apr 15, 2017

I fail to find what makes Travis complain. Any help?

---------------

.. missing description:
This group contains functions to ....
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This group contains functions to create and manipulate arrays?

eval Evaluates an expression which is passed in a string.
Useful to expand dynamic parameters passed as context
variables or fields
is_layer_visible Returns true if a specified layer is visible
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the lower case is used in expression string builder dialog

@SrNetoChan
Copy link
Member

SrNetoChan commented Apr 19, 2017

LGTM. Great work splitting 2.18 and 3.0 features

@DelazJ
Copy link
Collaborator Author

DelazJ commented Apr 19, 2017

Great work splitting 2.18 and 3.0 features

git add -p . is your friend :-)

@SrNetoChan
Copy link
Member

Have you seen git add -i It's also very cool.

@DelazJ
Copy link
Collaborator Author

DelazJ commented Apr 22, 2017

It looks like -p is a subcommand of -i. Is this PR mergeable?
I guess it would need to manually close the issues because the target branch (master) is not the default branch of the repo. In which case, is that possible for a maintainer to temporarily switch default branches, merge and restore default? /me lazy to browse 19 issues to close/

@SrNetoChan
Copy link
Member

I think you can merge it. And I would it will fix the issues anyway. Issues are not tied to a specific branch, I think.

@DelazJ
Copy link
Collaborator Author

DelazJ commented Apr 24, 2017

it will fix the issues anyway. Issues are not tied to a specific branch, I think.

Not sure, because of https://github.com/blog/1506-closing-issues-via-pull-requests and that I had to manually close issues that my recent master-related PRs were supposed to fix.
Anyway, I'll do that this evening when i have a git infrastructure to backport the 2.18 commit at the same time, and if nobody granted my request in the meantime.

@DelazJ DelazJ merged commit 0dbc63c into qgis:master Apr 26, 2017
@DelazJ
Copy link
Collaborator Author

DelazJ commented Apr 26, 2017

As I suspected, I had to close them one by one manually :(

@DelazJ DelazJ deleted the functions branch April 30, 2017 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants