-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some expression functions #1824
Conversation
I fail to find what makes Travis complain. Any help? |
--------------- | ||
|
||
.. missing description: | ||
This group contains functions to .... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This group contains functions to create and manipulate arrays?
eval Evaluates an expression which is passed in a string. | ||
Useful to expand dynamic parameters passed as context | ||
variables or fields | ||
is_layer_visible Returns true if a specified layer is visible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the lower case is used in expression string builder dialog
LGTM. Great work splitting 2.18 and 3.0 features |
|
Have you seen |
It looks like |
I think you can merge it. And I would it will fix the issues anyway. Issues are not tied to a specific branch, I think. |
Not sure, because of https://github.com/blog/1506-closing-issues-via-pull-requests and that I had to manually close issues that my recent master-related PRs were supposed to fix. |
As I suspected, I had to close them one by one manually :( |
As usual the first commit (@fd50093) is compatible with 2.18
I let some comments because of missing description in the application (and reported the bug on hub)
Fixes #1723, Fixes #1715, Fixes #1649, Fixes #1617, Fixes #1616, Fixes #1615, Fixes #1540, Fixes #1539, Fixes #1521, Fixes #1514, Fixes #1509, Fixes #1486, Fixes #1479, Fixes #1476, Fixes #1475, Fixes #1472, Fixes #1379, Fixes #1348, Fixes #1304