-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to Virtual layers section #1863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Would that be possible to insert a note about the possibility to create virtual layer from dbmanager also (in case it is 😄 )?
|
||
:ref:`Functions of QGIS expressions<functions_list>` can also be used in a | ||
:ref:`Functions of QGIS expressions<functions_list>` can also be used in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for reading, add a space before < character
* **geometry CRS**: this option allows to specify the coordinate reference | ||
system of the virtual layer. | ||
* Geometry :guilabel:`CRS`: this option allows to specify the | ||
coordinate reference system of the virtual layer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: I do not have QGIS in front of me.
From a user point of view, isn't it weird to not have geometry in the label of the last three options? Especially, column and type are not obvious that it's about geometry. (unless they are under a geometry section)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DelazJ your guess is right, see my screenshot :)
id) of existing vector layers as well as field names of these layers. | ||
The dialog allows you to specify a :guilabel:`Layer name` and a SQL | ||
:guilabel:`Query`. The | ||
query can use the name (or id) of loaded vector layers as well as field names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fields name, instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fields' names
as names of the fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, but i'd think that each field has ONE name (fields' name); I might be following french rules...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo to correct.
|
||
Spatial binary predicates like ``ST_Intersects`` are greatly sped up when used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
speed up when used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I have also learned only yesterday that the word sped
exists. It`s the past tense of the verb to speed. Since the phrase is in passive voice, both this forms would work.
are sped up
or
are speeded up
@DelazJ check if you are ok with the note about DB manager. |
* Adds embedded layers description Fixes #1809 * Improvements to Virtual layers * Virtual layers in DB manager * small improvements and fixes * Small fix
* Adds embedded layers description Fixes qgis#1809 * Improvements to Virtual layers * Virtual layers in DB manager * small improvements and fixes * Small fix
Adds embedded layers description Fixes #1809