Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Virtual layers section #1863

Merged
merged 5 commits into from
May 1, 2017

Conversation

SrNetoChan
Copy link
Member

Adds embedded layers description Fixes #1809

@SrNetoChan SrNetoChan requested review from DelazJ and yjacolin May 1, 2017 01:50
Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Would that be possible to insert a note about the possibility to create virtual layer from dbmanager also (in case it is 😄 )?


:ref:`Functions of QGIS expressions<functions_list>` can also be used in a
:ref:`Functions of QGIS expressions<functions_list>` can also be used in a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reading, add a space before < character

* **geometry CRS**: this option allows to specify the coordinate reference
system of the virtual layer.
* Geometry :guilabel:`CRS`: this option allows to specify the
coordinate reference system of the virtual layer.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: I do not have QGIS in front of me.
From a user point of view, isn't it weird to not have geometry in the label of the last three options? Especially, column and type are not obvious that it's about geometry. (unless they are under a geometry section)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DelazJ your guess is right, see my screenshot :)

spectacle w31599

id) of existing vector layers as well as field names of these layers.
The dialog allows you to specify a :guilabel:`Layer name` and a SQL
:guilabel:`Query`. The
query can use the name (or id) of loaded vector layers as well as field names
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fields name, instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fields' names as names of the fields

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, but i'd think that each field has ONE name (fields' name); I might be following french rules...

Copy link
Member

@yjacolin yjacolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo to correct.


Spatial binary predicates like ``ST_Intersects`` are greatly sped up when used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

speed up when used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I have also learned only yesterday that the word sped exists. It`s the past tense of the verb to speed. Since the phrase is in passive voice, both this forms would work.

are sped up

or

are speeded up

@SrNetoChan
Copy link
Member Author

@DelazJ check if you are ok with the note about DB manager.

@SrNetoChan SrNetoChan merged commit 6adf8af into qgis:release_2.18 May 1, 2017
SrNetoChan added a commit that referenced this pull request May 1, 2017
* Adds embedded layers description Fixes #1809
* Improvements to Virtual layers
* Virtual layers in DB manager
* small improvements and fixes
* Small fix
SrNetoChan added a commit to SrNetoChan/QGIS-Documentation that referenced this pull request May 1, 2017
* Adds embedded layers description Fixes qgis#1809
* Improvements to Virtual layers
* Virtual layers in DB manager
* small improvements and fixes
* Small fix
@SrNetoChan SrNetoChan deleted the virtual_layers branch May 16, 2017 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants