Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vector_properties.rst #2786

Merged
merged 3 commits into from
Jul 16, 2018
Merged

Update vector_properties.rst #2786

merged 3 commits into from
Jul 16, 2018

Conversation

stra2da
Copy link
Contributor

@stra2da stra2da commented Jul 13, 2018

renderer
Proposed changes are for consistency with the GUI and between the paragraphs describing the renderer.
Please note I didn't change the index

Proposed changes are for consistency with the GUI and between the paragraphs describing the renderer.
Please note I didn't change the index
@SrNetoChan
Copy link
Member

I agree with moving the "renderer" word from :guilabel: directives, but I wouls not remove them from titles.

@DelazJ
Copy link
Collaborator

DelazJ commented Jul 14, 2018

I agree with moving the "renderer" word from :guilabel: directives, but I wouls not remove them from titles

Agreed. And I would add it to those missing it.
I think it gives more meaning to the title.

@stra2da
Copy link
Contributor Author

stra2da commented Jul 14, 2018

Ok, I will move the "renderer" word from :guilabel: directives and add it to the titles missing it
(Inverted polygon, Heatmap).
I would change also the title "Rule-based rendering" into "Rule-base Renderer".
Ok?
I'll have to do another pull request for theese changes, not yet using git...

@DelazJ
Copy link
Collaborator

DelazJ commented Jul 14, 2018

OK for your suggestions!
No need to do a new pull request; you can do as many changes as you wish using the online github infrastructure: click the Files changed tab above and then the pencil next to the file name and you can edit the file.
Same procedure is to edit https://github.com/stra2da/QGIS-Documentation/blob/patch-3/source/docs/user_manual/working_with_vector/vector_properties.rst (the vector_properties file from your branch)

@DelazJ
Copy link
Collaborator

DelazJ commented Jul 14, 2018

I would change also the title "Rule-based rendering" into "Rule-base Renderer".

euh... rule-base or rule-based?

@stra2da
Copy link
Contributor Author

stra2da commented Jul 14, 2018

oh no!
Rule-based, I would change "rendering" with "renderer", according with the others titles :)

@DelazJ DelazJ merged commit 9e1c449 into qgis:release_2.18 Jul 16, 2018
@DelazJ
Copy link
Collaborator

DelazJ commented Jul 16, 2018

Thanks @stra2da

DelazJ pushed a commit that referenced this pull request Jul 16, 2018
Proposed changes are for consistency with the GUI and between the paragraphs describing the renderer.
Please note I didn't change the index

(cherry picked from commit 9e1c449)
@stra2da stra2da deleted the patch-3 branch July 16, 2018 07:48
stra2da added a commit to stra2da/QGIS-Documentation that referenced this pull request Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants