Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep n biggest parts of each feature and not layer #3385

Merged
merged 4 commits into from
Jan 23, 2019
Merged

Keep n biggest parts of each feature and not layer #3385

merged 4 commits into from
Jan 23, 2019

Conversation

DelazJ
Copy link
Collaborator

@DelazJ DelazJ commented Jan 21, 2019

havatv
havatv approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@havatv havatv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but should we describe the output in more detail in the text (same features, but with fewer parts, or non-multi geometry features ("duplication" of features)?

havatv
havatv reviewed Jan 21, 2019
View reviewed changes
Copy link
Contributor

@havatv havatv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to explain in more detail - hopefully not too much...

@havatv @DelazJ
Apply suggestions from code review
df95e56 
Co-Authored-By: DelazJ <delazj@gmail.com>
havatv
havatv reviewed Jan 23, 2019
View reviewed changes
Copy link
Contributor

@havatv havatv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another try.

havatv and others added 2 commits January 23, 2019 12:00
@havatv @DelazJ
Got a consensus ;)
04e02ad 
Co-Authored-By: DelazJ <delazj@gmail.com>
@DelazJ
Breaking lines
e4372a0
@havatv havatv merged commit 65e242a into qgis:master Jan 23, 2019
@havatv
Copy link
Contributor

havatv commented Jan 23, 2019

Done! :-)

@DelazJ DelazJ deleted the keepN branch January 23, 2019 12:10
@qgib qgib mentioned this pull request May 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havatv havatv havatv approved these changes

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DelazJ @havatv @nyalldawson