Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the fix me button #4200

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Hide the fix me button #4200

merged 3 commits into from
Sep 10, 2019

Conversation

DelazJ
Copy link
Collaborator

@DelazJ DelazJ commented Sep 4, 2019

Another attempt to remove fix me button on 2.18 pages (no more fixes on this branch - fix #3559)

Ticket: #

  • Backport to LTR documentation is required

Minimal requirements for merging (for maintainers)

  • The description of this PR is coherent with the manual and does not provide wrong information.
  • This PR passes the checks.

Copy link
Contributor

@havatv havatv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. But travis is complaining.

@SrNetoChan
Copy link
Member

Does not seem related to the PR. It's failing when trying to download the transifex package or something.

@SrNetoChan
Copy link
Member

It seems that the transifex-client needs to be updated. 0.9 is not compatible with Python 3:

transifex/transifex-client#38

So maybe jump to 0.12.5 (what is used in master now)?

@DelazJ
Copy link
Collaborator Author

DelazJ commented Sep 10, 2019

I wonder if it's worth the effort (though I don't know how big is the effort). A lot of things have changed since 2.18 (we upgrade sphinx and all the dependencies, add doctest and I think it's normal it fails). Is that not possible to (temporarily?) disconnect travis (from 2.18?) and merge my commit. Otherwise I could simply close both this PR and the (thus "unfixable") issue report (will try to live with that 😄 )

@SrNetoChan
Copy link
Member

If we disconnect travis, it wont build the docs, or will it? Can I try to patch your PR directly? I was trying to do a PR on your branch but it fails...

@DelazJ
Copy link
Collaborator Author

DelazJ commented Sep 10, 2019

Can I try to patch your PR directly?

Of course. Feel free to do whatever you think is right.

I was trying to do a PR on your branch but it fails...

That's weird but that's not the first time. My PR allows maintainers edit so normally you should be able to change it.

@SrNetoChan
Copy link
Member

Here you go! Done! :-D

@DelazJ
Copy link
Collaborator Author

DelazJ commented Sep 10, 2019

Great!

@DelazJ
Copy link
Collaborator Author

DelazJ commented Sep 10, 2019

Let's close another 2.x-period issue. Thanks @SrNetoChan .

@DelazJ DelazJ merged commit 43df851 into qgis:release_2.18 Sep 10, 2019
@DelazJ DelazJ deleted the fixMe_218 branch September 10, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants