-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide the fix me button #4200
Hide the fix me button #4200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK. But travis is complaining.
Does not seem related to the PR. It's failing when trying to download the transifex package or something. |
It seems that the transifex-client needs to be updated. 0.9 is not compatible with Python 3: So maybe jump to 0.12.5 (what is used in master now)? |
I wonder if it's worth the effort (though I don't know how big is the effort). A lot of things have changed since 2.18 (we upgrade sphinx and all the dependencies, add doctest and I think it's normal it fails). Is that not possible to (temporarily?) disconnect travis (from 2.18?) and merge my commit. Otherwise I could simply close both this PR and the (thus "unfixable") issue report (will try to live with that 😄 ) |
If we disconnect travis, it wont build the docs, or will it? Can I try to patch your PR directly? I was trying to do a PR on your branch but it fails... |
Of course. Feel free to do whatever you think is right.
That's weird but that's not the first time. My PR allows maintainers edit so normally you should be able to change it. |
Here you go! Done! :-D |
Great! |
Let's close another 2.x-period issue. Thanks @SrNetoChan . |
Another attempt to remove fix me button on 2.18 pages (no more fixes on this branch - fix #3559)
Ticket: #
Minimal requirements for merging (for maintainers)