-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show "end of life" notice in header bar #4273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure there's a proper/better sphinx way of doing it. Besides, no more changes are expected in this branch so, some degree of hardcoding is allowed. :-)
I think you need to rebase this to get the latest changes on this branch to fix the building. |
To me it looks like the branch is just too old to build (last rebuild was 2 years ago), I had to do some quirks to get it to build locally too |
Somehow yes (it's definitely better than nothing!), don't count on me to do much more here. |
So the next move will be to merge this, apply the fix to releases up to 2.18 and rebuild each of them to get the message online. Right? |
Co-Authored-By: Harrissou Sant-anna <delazj@gmail.com>
Looks good to merge. I think we could also use this for the testing version warning. I will give it a try once this is merged and applied to old versions. |
@SrNetoChan I'd propose to backport #4274 instead |
References #3452
There's a lot of hardcoding in there.
It will need some sphinx etc. pro to make it translatable et al.
Goal:
Ticket(s): #