Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "end of life" notice in header bar #4273

Merged
merged 3 commits into from
Oct 14, 2019
Merged

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Oct 6, 2019

References #3452

image

There's a lot of hardcoding in there.
It will need some sphinx etc. pro to make it translatable et al.

Goal:

Ticket(s): #

  • Porting to several other doc versions which are EOL is required

Copy link
Member

@SrNetoChan SrNetoChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure there's a proper/better sphinx way of doing it. Besides, no more changes are expected in this branch so, some degree of hardcoding is allowed. :-)

@SrNetoChan
Copy link
Member

I think you need to rebase this to get the latest changes on this branch to fix the building.

@m-kuhn
Copy link
Member Author

m-kuhn commented Oct 6, 2019

I think you need to rebase this to get the latest changes on this branch to fix the building.

To me it looks like the branch is just too old to build (last rebuild was 2 years ago), I had to do some quirks to get it to build locally too

@m-kuhn
Copy link
Member Author

m-kuhn commented Oct 6, 2019

Not sure there's a proper/better sphinx way of doing it. Besides, no more changes are expected in this branch so, some degree of hardcoding is allowed. :-)

Somehow yes (it's definitely better than nothing!), don't count on me to do much more here.
But eventually this will be on master as well, controlled by a (deactivated) flag and be shown translated and directly send the user to the localized version of the current docs.

@DelazJ
Copy link
Collaborator

DelazJ commented Oct 11, 2019

So the next move will be to merge this, apply the fix to releases up to 2.18 and rebuild each of them to get the message online. Right?

Co-Authored-By: Harrissou Sant-anna <delazj@gmail.com>
@SrNetoChan
Copy link
Member

Looks good to merge. I think we could also use this for the testing version warning. I will give it a try once this is merged and applied to old versions.

@m-kuhn m-kuhn merged commit 76a73f0 into qgis:manual_en_v2.8 Oct 14, 2019
@m-kuhn m-kuhn deleted the game_over branch October 14, 2019 07:13
@m-kuhn
Copy link
Member Author

m-kuhn commented Oct 14, 2019

@SrNetoChan I'd propose to backport #4274 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants