Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text and images in Lesson 4.3 "Classification" #5524

Merged
merged 6 commits into from May 18, 2020

Conversation

Codym48
Copy link
Contributor

@Codym48 Codym48 commented May 18, 2020

Give Lesson 4.3 similar scrubbing to what Lesson 4.2 received in #5463:

I think this warrants:

  • Backport to LTR documentation is required

Give Lesson 4.3 similar scrubbing that Lesson 4.2 received in qgis#5463:
 - Switch from bulleted lists to numbered lists
 - Update missing options (Column) to represent their new name (Value)
 - Update images to reflect QGIS master branch (3.13+)
 - Remove steps and images for removing borders from landuse layers
   since they were already removed in Lesson 3.2
 - Use proper :sup: formatting for button popup text

Your dialog should now look like this:
These filters are exclusive, in that they collectively exclude some areas
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two related questions:

  1. Are we ok leaving all of the text blocks like "These filters are exclusive..." 3-spaced over rather than left-justified? This is required to continue the list numbering below (15.) instead of starting over (1.)
  2. Should "Click and drag this criterion to the top of the list" end with a period in the new approach? It now has additional text just beneath it.

Old approach

image

New approach

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we ok leaving all of the text blocks like "These filters are exclusive..." 3-spaced over rather than left-justified? This is required to continue the list numbering below (15.) instead of starting over (1.)

It's clear that "Apply the symbology" should be part of the steps so "these filters ..." needs to be indented.
Given that the "these filters.." is about the three previous steps, explaining how they behave, another approach can be to consider rule addition as a whole, ie

  1. Add a set of rules as follow: (<== replace with whatever you like)

    1. Add a new rule "landuse" <> 'residential' AND "AREA" >= 605000 and choose a mid-green color
    2. Add another new rule "name" = 'Swellendam' and assign it a darker grey-blue color in order to indicate the town's importance in the region
    3. Click and drag this criterion to the top of the list.

    These filters are exclusive, in that they collectively exclude some areas...

  2. Apply this symbology.

Should "Click and drag this criterion to the top of the list" end with a period in the new approach? It now has additional text just beneath it.

Yes, imho

Copy link
Contributor

@havatv havatv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@DelazJ
Copy link
Collaborator

DelazJ commented May 18, 2020

Update missing GUI options (Column) to represent their new name (Value)

Regarding backports, this is 3.12+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants