Update the TM Using Print Layout lesson to QGIS 3 #5669

havatv · 2020-06-08T12:59:16Z

Goal: Update the TM Using Print Layout lesson to QGIS 3

Ticket(s): Fixes #3312, fixes #3311, fix #3313, fixes #3315.

Backport to LTR documentation is required

DelazJ · 2020-06-08T19:52:53Z

docs/training_manual/map_composer/map_composer.rst

@@ -21,7 +21,8 @@ reason, it has a tool called the :guilabel:`Layout Manager`.

 * Click on the :menuselection:`Project --> Layout Manager` menu entry to open


not numbered list?

Sorry, missed this one. Will try to fix.
Fixed now (and even found some more ;-) ).

docs/training_manual/map_composer/map_composer.rst

@DelazJ

Thanks, @DelazJ! Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>

havatv

Thanks.

havatv · 2020-06-08T20:33:23Z

docs/training_manual/map_composer/map_composer.rst

@@ -21,7 +21,8 @@ reason, it has a tool called the :guilabel:`Layout Manager`.

 * Click on the :menuselection:`Project --> Layout Manager` menu entry to open


Sorry, missed this one. Will try to fix.
Fixed now (and even found some more ;-) ).

DelazJ

Here a review I couldn't send before the PR got merged but I think there are valuable concerns that need to be addressed in it (some logic and steps have changed from the 2.x and 1.x periods).

docs/training_manual/map_composer/map_composer.rst

DelazJ · 2020-06-09T05:23:40Z

docs/training_manual/map_composer/map_composer.rst

@@ -220,18 +220,18 @@ Not everything on the legend is necessary, so let's remove some unwanted items.

 #. In the :guilabel:`Item Properties` tab, you'll find the
   :guilabel:`Legend items` panel.
-#. Select the :guilabel:`buildings` entry.
+#. Select the :guilabel:`training_data_buildings` entry.


Which layer is this one? I suspect it's a bug in how you load the layer in QGIS: I remember I had situation where it concatenates layer and table names when loading. Cannot reproduce right now, but I think this is not the expected name.

This is the name it gets when you load it from the geopackage training_data.gpg. And that is the only place where I have found buildings.

This is a bug. I've also seen it in the past. Not sure what triggers that. see what I get loading that file, here.

I have updated the text.

DelazJ · 2020-06-09T05:24:27Z

docs/training_manual/map_composer/map_composer.rst

@@ -11,16 +11,16 @@ So for someone who doesn't have the data or the same GIS program
 Luckily, QGIS can export its map file to a format that anyone's
 computer can read, as well as printing out the map if you have a
 printer connected.
-Both exporting and printing is handled via the print layout.
+Both exporting and printing is handled via the *Print Layout*.


Any reason you put print layout in italics?

Because it is a QGIS tool.

DelazJ · 2020-06-09T05:29:24Z

docs/training_manual/map_composer/map_composer.rst

+Go to the main QGIS window (the one with the :guilabel:`Layers` panel
+and all the other familiar elements you were working with before),
+and save your project from there as usual.


This is no more necessary, you can save from within the print layout window.

Suggested change

Go to the main QGIS window (the one with the :guilabel:`Layers` panel

and all the other familiar elements you were working with before),

and save your project from there as usual.

#. Go to the :menuselection:`Layout -->` |fileSave| :menuselection:`Save Project`.

This is a convenient shortcut to the one in the main dialog.

/!\ remember substitution...

docs/training_manual/map_composer/map_composer.rst

DelazJ · 2020-06-09T06:08:14Z

docs/training_manual/map_composer/map_composer.rst

-* Click :guilabel:`Save`.
+#. Click the |saveAsPDF| :sup:`Export as PDF` button
+#. Choose a save location and a file name as usual.
+#. Click :guilabel:`Save`.


We should tell them a minima to validate the pdf properties options dialog that pops up, as is

DelazJ · 2020-06-09T10:34:23Z

docs/training_manual/map_composer/map_composer.rst


-* Click and drag a box on the blank page:
+#. Click and drag a box on the blank page:


Actually, before you ever click on the map, you have the "new item properties" dialog to deal with.
We should indicate the map size and placement to use here

DelazJ · 2020-06-09T10:37:34Z

docs/training_manual/map_composer/map_composer.rst


-* Click on the page, above the map, and a label will appear at the top of the
-  map.
+#. Click on the page, above the map, and a label will appear at the


new item properties dialog again to play with. They SHOULD be advised to use a lower height here otherwise they get a label item with the map height

The default height seems to be OK as a starter (does not seem to get the "map height").

DelazJ · 2020-06-09T10:43:14Z

docs/training_manual/map_composer/map_composer.rst

+#. Close the layout window
+#. Save your map
+#. Find your exported PDF using your operating system's file manager


I'm not sure of the order here. But in the layout window, there's already a link that shows as soon as the PDF is created. They just have to click on it to open the pdf folder.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

havatv · 2020-06-09T15:17:26Z

Here a review I couldn't send before the PR got merged but I think there are valuable concerns that need to be addressed in it (some logic and steps have changed from the 2.x and 1.x periods).

Thanks! I have updated in #5677.

* Updates after review * Indentation * Moving the layout element lock part down * Update locking mentions * Update locking mentions * Fix reference to the building data set in the training_data.gpkg (GeoPackage) file

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

havatv added 2 commits June 8, 2020 14:03

Update the TM Using Print Layout lesson to QGIS 3

fb1d134

spell checking

3762f50

DelazJ reviewed Jun 8, 2020

View reviewed changes

Apply suggestions from code review

f5f0a47

Thanks, @DelazJ! Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>

havatv commented Jun 8, 2020

View reviewed changes

havatv added 2 commits June 8, 2020 23:06

change to enumeration lists and some line length adjustments

cac7a96

Adding :sup:s for icons

a3ca37e

havatv added the backport release_3.10 label Jun 8, 2020

Some more edits

5523e2a

havatv merged commit 71cb903 into master Jun 9, 2020

delete-merged-branch bot deleted the tm_layout branch June 9, 2020 06:53

qgis-bot mentioned this pull request Jun 9, 2020

[Backport release_3.10] Update the TM Using Print Layout lesson to QGIS 3 #5671

Merged

havatv mentioned this pull request Jun 9, 2020

Adjusting a few too long lines (clean-up after #5669) #5672

Merged

1 task

qgis-bot pushed a commit to qgis-bot/QGIS-Documentation that referenced this pull request Jun 9, 2020

Adjusting a few too long lines (clean-up after qgis#5669)

1019d85

DelazJ reviewed Jun 9, 2020

View reviewed changes

havatv pushed a commit that referenced this pull request Jun 9, 2020

Adjusting a few too long lines (clean-up after #5669) (#5673)

80ca9c3

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

havatv mentioned this pull request Jun 9, 2020

Updates after review of #5669 (training manual - layout) #5677

Merged

1 task

qgis-bot pushed a commit to qgis-bot/QGIS-Documentation that referenced this pull request Jun 11, 2020

Updates after review of qgis#5669 (training manual - layout)

d3d04bf

havatv pushed a commit that referenced this pull request Jun 11, 2020

Updates after review of #5669 (training manual - layout) (#5680)

679ff4b

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

DelazJ mentioned this pull request Jun 14, 2020

Create and update QGIS screenshots #2441

Open

41 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the TM Using Print Layout lesson to QGIS 3 #5669

Update the TM Using Print Layout lesson to QGIS 3 #5669

havatv commented Jun 8, 2020 •

edited

DelazJ Jun 8, 2020

havatv Jun 8, 2020 •

edited

havatv left a comment

havatv Jun 8, 2020 •

edited

DelazJ left a comment

DelazJ Jun 9, 2020

havatv Jun 9, 2020

DelazJ Jun 10, 2020

havatv Jun 10, 2020

DelazJ Jun 9, 2020

havatv Jun 9, 2020

DelazJ Jun 9, 2020

DelazJ Jun 9, 2020

DelazJ Jun 9, 2020

DelazJ Jun 9, 2020

havatv Jun 9, 2020

DelazJ Jun 9, 2020

havatv commented Jun 9, 2020 •

edited

		@@ -21,7 +21,8 @@ reason, it has a tool called the :guilabel:`Layout Manager`.

		* Click on the :menuselection:`Project --> Layout Manager` menu entry to open


		* Click and drag a box on the blank page:
		#. Click and drag a box on the blank page:

Update the TM Using Print Layout lesson to QGIS 3 #5669

Update the TM Using Print Layout lesson to QGIS 3 #5669

Conversation

havatv commented Jun 8, 2020 • edited

Choose a reason for hiding this comment

havatv Jun 8, 2020 • edited

Choose a reason for hiding this comment

havatv left a comment

Choose a reason for hiding this comment

havatv Jun 8, 2020 • edited

Choose a reason for hiding this comment

DelazJ left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

havatv commented Jun 9, 2020 • edited

havatv commented Jun 8, 2020 •

edited

havatv Jun 8, 2020 •

edited

havatv Jun 8, 2020 •

edited

havatv commented Jun 9, 2020 •

edited