-
-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector symbology batch update #6997
Conversation
@roya0045 Can you split up the PR so that 3.24 features are moved to another one? master is currently targeting 3.22LTR so until we set up a branch and release 3.22 docs, we cannot merge these |
Sure thing! |
a51abee
to
b17bf9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing some review
Merged Features Renderer | ||
.................... | ||
|
||
The |mergedFeaturesSymbol| :guilabel:`Merged Features` renderer is a meta-renderer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The symbol referenced by the |mergedFeaturesSymbol| substitution does not exist yet in the repo. You need to create and load it (https://docs.qgis.org/testing/en/docs/documentation_guidelines/substitutions.html#usage)
This variable forces the rendering to be displayed as if the layer was | ||
at the provided scale, regardless of the scale of the map extent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using "variable" is confusing as it might mean things like @...
. "option" looks more appropriate to me.
This description does not look correct to me (or I don't understand it) and I feel like it contradicts the next paragraph. The scale is actually taken into consideration, leading to the size scaling. #6790 explains that well IMHO.
at the provided scale, regardless of the scale of the map extent. | ||
|
||
In the case where the reference scale is set at 1:1000 and | ||
use a width of 1mm to render a line. If the map is at a scale of 1: 10 000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use a width of 1mm to render a line. If the map is at a scale of 1: 10 000 | |
the line uses a width of 1mm to render, if the map is at a scale of 1: 10 000 |
We can also reuse the sentence in the GUI or the issue report.
@DelazJ The embeded render doesn't have an icon, I'm not sure if I should remove the substitution or not. |
@roya0045 no icon then no substitution possible. We will add one if ever the renderer has an icon (qgis/QGIS#42071) |
Good, should be fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roya0045 Sorry for the delay.
4f6414d
to
6f5c170
Compare
Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3.22 release_3.22
# Navigate to the new working tree
cd .worktrees/backport-release_3.22
# Create a new branch
git switch --create backport-6997-to-release_3.22
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick f841693bcf790953b01565a10cd242ec1f1409c4,b595f36b6695207a515b743a1ba4a92f44ab39c3,870768a9c196ed075ff98b6fe4c4ffedfd7bb466,ea71b1cde6f33aec123cd43d3826a34366200e78,0a82e58611854b6fb49512d95e0f1df882ead796,05bcecb7113e9d8adb2dc4867198549dae85cb18,831086891250f7ab424d2df153ddc9f423145652,39c304247d0637fb112f36f0cf3b167e5ff30bd8,02880d02840954f5a2c6f77c44b46119ceec77fa,8e9e1e50c295473c4ec0104887e20519bf14a4a1,71d8b4df3be067de3dddf39f041a2344be71bd42,34babfe0ecd5e36055b9e09edd4a69a00ce1364b,88837eb1a9932fcd30fdde98306f3a59f9f42044,b9dc1863206e16a97d06d957bf82d9b49896d2e4,6f5c170107a208f1c8c6babac609668edc486801,47fe4fd9c5e1fac06a133cd7ec6d89e752d9ca79,3a27d7f45bffd9ca8a74c21ca3898b7872759083
# Push it to GitHub
git push --set-upstream origin backport-6997-to-release_3.22
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3.22 Then, create a pull request where the |
Fixes #6421 Fixes #6571 Fixes #6692 Fixes #6715 Fixes #6790 Fixes #6948
Proposal to update the vector symbology sections.
Images still need to be added.