Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy choice added in layer properties issue #8084 #8447

Merged
merged 6 commits into from
Sep 14, 2023

Conversation

selmaVH1
Copy link
Collaborator

@selmaVH1 selmaVH1 commented Aug 17, 2023

Fixes #8084

@selmaVH1 selmaVH1 added this to In progress in Selma Work Planning Aug 21, 2023
@selmaVH1 selmaVH1 moved this from In progress to Review in progress in Selma Work Planning Aug 22, 2023
Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously I forgot to publish this review.
I have a few suggestions (and a number of them are open questions 😄 )

Comment on lines 2423 to 2424

.. _constraints:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This belongs to the constraints section so should move with it

Suggested change
.. _constraints:

^^^^^^^^

* :guilabel:`Policies` allows you to easily determine the current policy when splitting
features, you can change it as desired:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
features, you can change it as desired:

features, you can change it as desired:

* :guilabel:`Duplicate Values`: Copies the current field value without change.
* :guilabel:`Use Default Value`: Resets the field by recalculating its defaults values.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* :guilabel:`Use Default Value`: Resets the field by recalculating its defaults values.
* :guilabel:`Use Default Value`: Resets the field by recalculating its :ref:`default value <default_values>`.

@nyalldawson if no default value or expression exists for the field, it falls back to the "duplicate value" option, right? That one is the default, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm -- good question. I believe it will be copied, yes.


* :guilabel:`Duplicate Values`: Copies the current field value without change.
* :guilabel:`Use Default Value`: Resets the field by recalculating its defaults values.
* :guilabel:`Remove Value`: Clears the field to an unset state.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation, here and below

Suggested change
* :guilabel:`Remove Value`: Clears the field to an unset state.
* :guilabel:`Remove Value`: Clears the field to an unset state.

* :guilabel:`Duplicate Values`: Copies the current field value without change.
* :guilabel:`Use Default Value`: Resets the field by recalculating its defaults values.
* :guilabel:`Remove Value`: Clears the field to an unset state.
* :guilabel:`Use Ratio Geometries`: Recalculates the field value for all split portions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* :guilabel:`Use Ratio Geometries`: Recalculates the field value for all split portions
* :guilabel:`Use Ratio Geometries`: Recalculates the field value for all split portions

* :guilabel:`Use Default Value`: Resets the field by recalculating its defaults values.
* :guilabel:`Remove Value`: Clears the field to an unset state.
* :guilabel:`Use Ratio Geometries`: Recalculates the field value for all split portions
by multiplying the existing value by ratio of the split parts lengths or areas.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
by multiplying the existing value by ratio of the split parts lengths or areas.
by multiplying the existing value by ratio of the split parts lengths or areas.

@selmaVH1 selmaVH1 moved this from Review in progress to In progress in Selma Work Planning Sep 6, 2023
@selmaVH1 selmaVH1 moved this from In progress to Review in progress in Selma Work Planning Sep 12, 2023
@DelazJ DelazJ merged commit ba6239c into qgis:master Sep 14, 2023
3 checks passed
Selma Work Planning automation moved this from Review in progress to Done Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Expose field split policy choice in layer properties > form dialog (Request in QGIS)
3 participants