Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots updated fixes #8458 #8462

Merged
merged 2 commits into from
Aug 27, 2023
Merged

Screenshots updated fixes #8458 #8462

merged 2 commits into from
Aug 27, 2023

Conversation

selmaVH1
Copy link
Collaborator

fixes #8458
Screenshots updated for chapter 9. Module: Plugins

Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@selmaVH1 there are also the dataplotly screenshots to resize, they are way too big and airy (compared to the others, and for what they are showing). Thanks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resize this screenshot, please? It is unnecessarily too big.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DelazJ You can check it now.

@DelazJ
Copy link
Collaborator

DelazJ commented Aug 25, 2023

there are also the dataplotly screenshots to resize, they are way too big and airy

Sorry Selma, i wasn't clear enough. I was talking about the screenshots at https://docs.qgis.org/testing/en/docs/training_manual/qgis_plugins/plugin_examples.html#basic-fa-the-dataplotly-plugin that were made too high.

@selmaVH1
Copy link
Collaborator Author

there are also the dataplotly screenshots to resize, they are way too big and airy

Sorry Selma, i wasn't clear enough. I was talking about the screenshots at https://docs.qgis.org/testing/en/docs/training_manual/qgis_plugins/plugin_examples.html#basic-fa-the-dataplotly-plugin that were made too high.

@DelazJ I misunderstand you, this DataPlotly plugin doesn't work for me, but I didn't inspect the error that I get. Is it ok to resize existing images or should I take new ones?

@DelazJ DelazJ mentioned this pull request Aug 27, 2023
1 task
@DelazJ
Copy link
Collaborator

DelazJ commented Aug 27, 2023

this DataPlotly plugin doesn't work for me

Confirmed. It requires pandas installation. This is not mentioned in the install or metadata details (and actually the opposite is mentioned at https://github.com/ghtmtt/DataPlotly/tree/master#usage). Needs an update, @ghtmtt?

Is it ok to resize existing images or should I take new ones?

While at checking and fixing the install error, I updated the screenshots in #8476

@DelazJ DelazJ merged commit 6c9dbf8 into qgis:master Aug 27, 2023
3 checks passed
DelazJ pushed a commit to DelazJ/QGIS-Documentation that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 Module Plugins
2 participants