Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Georeferencer update issue #3193 #8498

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Georeferencer update issue #3193 #8498

merged 2 commits into from
Sep 15, 2023

Conversation

selmaVH1
Copy link
Collaborator

@selmaVH1 selmaVH1 commented Sep 7, 2023

fixes #3193
Screenshots updated, as well as icons. I also made some changes in the text and added automatically save GCP Points option.

Comment on lines 238 to 239
* The |checkbox| :guilabel:`Save GCP Points` automatically save GCP Points in the
raster-modified path.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't run the georeferencer recently so just an assumption.

Suggested change
* The |checkbox| :guilabel:`Save GCP Points` automatically save GCP Points in the
raster-modified path.
* The |checkbox| :guilabel:`Save GCP Points` will store GCP Points in a file next to the output raster.

?
Not clear what "raster-modified path" refers to, and using same "wording" as in next line.
And the "automatically" looks a bit confusing to me. This will happen when I generate the output, not as soon as I add a gcp point in the process (at this step the raster modified is probably not created, yet), doesn't it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DelazJ yes, that make sense. Thanks

@DelazJ DelazJ merged commit 7da1461 into qgis:master Sep 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add dX, dY and residual on GCP Points (#8513)
2 participants