Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map render profiler added to Debugging/Development tools #8506 #8512

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

selmaVH1
Copy link
Collaborator

fixes #8506

@DelazJ I added Map Render, but we should probably describe Startup and Project Load too, but for that I need some explanations because I'm not sure that I know how to describe those tools properly.
chrome_LN6Qj58lXt

Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Some suggestions below

Comment on lines 653 to 654
* |stopwatch| :guilabel:`Profiler` - under this tab you can choose one out
of three categories:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* |stopwatch| :guilabel:`Profiler` - under this tab you can choose one out
of three categories:
* |stopwatch| :guilabel:`Profiler` - under this tab you can choose one out of these categories:

Don't underestimate how quickly our devs can add more options to this feature and have your text (and its translations) obsolete/broken 😃

Comment on lines 656 to 657
* :guilabel:`Startup`
* :guilabel:`Project Load`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* :guilabel:`Startup`
* :guilabel:`Project Load`
* :guilabel:`Startup`: helps you diagnose (and fix) occasional long startup times of QGIS
* :guilabel:`Project Load`: helps you identify the causes of slow project load times

Picked at qgis/QGIS#36509 and #5772 Feel free to reword as you want

@DelazJ DelazJ merged commit 8f247a3 into qgis:master Sep 15, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add map render profiler (Request in QGIS)
2 participants