Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate expression added to modeler tools #8550

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

selmaVH1
Copy link
Collaborator

fixes #8474

Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@selmaVH1 what do you think about adding the other comments in the issue report. While not specifically in the code, it helps understand why and when to use it, hence probably helpful for many users. I'm referring to

It avoids the need to use the same expression multiple times throughout a model if the same result needs to be used more than once, and also permits use cases which otherwise are not possible (e.g. generating a timestamp value once and then reusing this throughout a model -- if every use recalculated the timestamp then the values would differ during the model's runtime)


Calculate expression
--------------------
Calculate the results of a QGIS expression and make
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Calculate the results of a QGIS expression and make
|334|
Calculates the result of a QGIS expression and makes

and mention substitution at the end of file.

- Name
- Type
- Description
* - **Field**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* - **Field**
* - **Input**

Comment on lines 51 to 52
* - **Output**
- ``Value``
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* - **Output**
- ``Value``
* - **Value**
- ``OUTPUT``

I think there is a switch here (https://github.com/qgis/QGIS/pull/54358/files#diff-dc398bcb04bd91d852555624aeccefce91fe509dc7ad879ba12ce978d67fa238R82)

@DelazJ DelazJ merged commit 3af4134 into qgis:master Oct 17, 2023
3 checks passed
@selmaVH1 selmaVH1 added this to Done in Selma Work Planning Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[processing] Add a new 'Calculate expression' algorithm for use in models (Request in QGIS)
2 participants