Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for identify tool inside the vector chapter #8864

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

selmaVH1
Copy link
Collaborator

The identify tool description for vector data.
Discussed in #8764.

Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @selmaVH1 for taking care of these adjustments.

IMHO, the main point in mentioning the identify features tool in each data provider chapter is to stop patching the "feature information" section with various "if this format, you also have that" and fully highlight specific outputs of each format in a dedicated place. Indeed, depending on whether you query a raster, vector or mesh you won't get the same type of contents for "attributes" and "derived" results, as well as the contextual menu. I am thus missing the vector outputs here i.e. most of the feature information section (and probably the text about contextual menu items). Or did I misunderstand the idea?

@@ -111,6 +111,23 @@ calculations to all or part of the features in the layer. This bar uses the same
Calculator` (see :ref:`calculate_fields_values`).


Using the Identify Tool with Attribute Table
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks confusing to me to have a section about "Identify features" in the middle of the attribute table interface description. That is not part of the attribute table. And not really something you use with the attribute table. It helps query attributes, reason why this chapter looked the most suitable but to me it is quite another type of tool. Can you find a better place in the page, please?

--------------------------------------------

The |identify| :guilabel:`Identify features` tool can be used to display all attributes
of a feature from the attribute table in the :guilabel:`Identify Results` dialog.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of a feature from the attribute table in the :guilabel:`Identify Results` dialog.
of a feature in the map canvas, without having to search for it in the attribute table.

Let's move up identify features plus-value mentioned at the end. feel free to reword.

Comment on lines 127 to 129
the clicked feature. This tool allows you to quickly view and verify all data
that the vector layer stores in its attribute table for specific features,
without having to search for them in the attribute table.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these are general info on the tool and close to the text in introduction, let's just provide the info there.

Suggested change
the clicked feature. This tool allows you to quickly view and verify all data
that the vector layer stores in its attribute table for specific features,
without having to search for them in the attribute table.

Using the Identify Tool with Attribute Table
--------------------------------------------

The |identify| :guilabel:`Identify features` tool can be used to display all attributes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here or next paragraph, can you ref the identify features section?

Comment on lines 122 to 126
* Select the vector layer in the Layers panel.
* Click on the :guilabel:`Identify features` tool in the toolbar or press :kbd:`Ctrl+Shift+I`.
* Click on a feature in the map view.

:guilabel:`Identify Results` dialog will open and display information about
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use numbered list for steps

Suggested change
* Select the vector layer in the Layers panel.
* Click on the :guilabel:`Identify features` tool in the toolbar or press :kbd:`Ctrl+Shift+I`.
* Click on a feature in the map view.
:guilabel:`Identify Results` dialog will open and display information about
#. Select the vector layer in the Layers panel.
#. Click on the :guilabel:`Identify features` tool in the toolbar or press :kbd:`Ctrl+Shift+I`.
#. Click on a feature in the map view.
The :guilabel:`Identify Results` dialog will open and display information about the clicked feature.

Then we need to provide what type of results is returned for vector layer

@selmaVH1
Copy link
Collaborator Author

IMHO, the main point in mentioning the identify features tool in each data provider chapter is to stop patching the "feature information" section with various "if this format, you also have that" and fully highlight specific outputs of each format in a dedicated place. Indeed, depending on whether you query a raster, vector or mesh you won't get the same type of contents for "attributes" and "derived" results, as well as the contextual menu. I am thus missing the vector outputs here i.e. most of the feature information section (and probably the text about contextual menu items). Or did I misunderstand the idea?

Hi @DelazJ, thanks for the review. Your feedback clarifies what needs to be addressed, it seems I misunderstood the idea.

@selmaVH1 selmaVH1 added this to In progress in Selma Work Planning Feb 20, 2024
@DelazJ DelazJ added the backport release_3.34 On merge create a backported pull request to 3.34 label Feb 28, 2024
@DelazJ DelazJ merged commit 5cbfb66 into qgis:master Feb 28, 2024
4 checks passed
Selma Work Planning automation moved this from In progress to Done Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3.34 On merge create a backported pull request to 3.34
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants