-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point cloud classification update #9006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @selmaVH1
May I suggest to update the "extent only" screenshot (misses triangulate setting) and the "3D view" screenshot (uses the classification renderer, hence misses the percentage and size options)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clip the image to the part related to "classification" settings? this will help to show the whole classes and keep coherence with the other renderers described above. Also we don't really need to show the other parameters; they hide your message and were already shown in the "extent only" section.
table, the :guilabel:`Color`, the :guilabel:`Size`, the :guilabel:`Value` | ||
and the :guilabel:`Legend` can be modified (for the :guilabel:`Color`, the :ref:`color-selector` widget opens). | ||
Assigning a :guilabel:`Size` value of 0 to a category will revert it to use | ||
the default point size set for the layer. | ||
The :guilabel:`Percentage` column will show you the representation of the category | ||
within the layer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that the number of options are growing, what do you think about 👇🏻, allowing to move details next to specific option
table, the :guilabel:`Color`, the :guilabel:`Size`, the :guilabel:`Value` | |
and the :guilabel:`Legend` can be modified (for the :guilabel:`Color`, the :ref:`color-selector` widget opens). | |
Assigning a :guilabel:`Size` value of 0 to a category will revert it to use | |
the default point size set for the layer. | |
The :guilabel:`Percentage` column will show you the representation of the category | |
within the layer. | |
table, you can modify: | |
* the :guilabel:`Color`: the :ref:`color-selector` widget opens | |
* the :guilabel:`Size`: assigning a size of ``0`` to a category will revert it to use | |
the default ref:`point size <pointsymbol_size>` set for the layer | |
* the :guilabel:`Value` | |
* the :guilabel:`Legend` | |
The :guilabel:`Percentage` column will show you the representation of the category | |
within the layer. |
Line 419 would then require the pointsymbol_size anchor addition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it should go there, and up to you if you want to add it in this PR or another. All these features belong to master only.
Note that there is some related description in the 3D properties section, and also I pulled the corresponding issue #9024 we can take information (and rendering examples?) from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I didn't saw this #9024 issue... I will create another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal, I looked for the original PR and initiated the issue creation after your other message.
… text suggestions added
fixes #8893