Show current and next releases in the roadmap counter box #313
Conversation
WalkthroughThe changes enhance the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- data/conf.json (1 hunks)
- scripts/update-schedule.py (3 hunks)
- themes/hugo-bulma-blocks-theme/assets/sass/bulma/components/roadmap.sass (1 hunks)
- themes/hugo-bulma-blocks-theme/layouts/shortcodes/roadmap.html (3 hunks)
Files skipped from review due to trivial changes (2)
- data/conf.json
- themes/hugo-bulma-blocks-theme/assets/sass/bulma/components/roadmap.sass
Additional context used
Ruff
scripts/update-schedule.py
45-45: Use context handler for opening files
(SIM115)
Additional comments not posted (5)
scripts/update-schedule.py (2)
40-41: LGTM!The new variables
next_ltr_versionandnext_lr_versionare correctly initialized toNone.
141-142: LGTM!The new variables
next_lr_versionandnext_ltr_versionare correctly set based on the input data.themes/hugo-bulma-blocks-theme/layouts/shortcodes/roadmap.html (3)
13-21: LGTM!The updated code correctly displays the current releases
ltrreleaseandreleasefrom the configuration data.
80-88: LGTM!The updated code correctly displays the next releases
next_ltr_versionandnext_lr_versionfrom the configuration data.
106-111: LGTM!The updated code correctly displays the current development version
devversionfrom the configuration data.
|
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- themes/hugo-bulma-blocks-theme/assets/sass/bulma/components/roadmap.sass (3 hunks)
- themes/hugo-bulma-blocks-theme/layouts/shortcodes/roadmap.html (6 hunks)
Additional comments not posted (18)
themes/hugo-bulma-blocks-theme/assets/sass/bulma/components/roadmap.sass (8)
24-24: Approved: Addedposition: relativeto.roadmapclass.This change ensures that the
.right-ribbonelement is correctly positioned relative to the.roadmapcontainer.
30-30: Approved: Increasedmax-widthfor.steps-contentto200px.This change likely improves the layout on mobile devices.
33-35: Approved: Added mobile rule fordivelements inside.steps-content.This change ensures better layout on mobile devices.
66-66: Approved: Setmargin-leftto0for.steps-content.This change ensures proper alignment of
.steps-content.
68-68: Approved: Setmargin-leftto0.75remfor.steps-contenton mobile devices.This change ensures better spacing and layout on mobile devices.
81-81: Approved: Modifiedmarginproperties for.help-tipclass.This change likely improves the positioning and alignment of the
.help-tipelement.
149-212: Approved: Added new styles for.right-ribbonelement.These styles define the positioning, appearance, and variations for the
.right-ribbonelement.
180-212: Approved: Added new styles for pseudo-elements::beforeand::afterof.right-ribbon span.These styles enhance the appearance of the
.right-ribbonelement by adding decorative borders.themes/hugo-bulma-blocks-theme/layouts/shortcodes/roadmap.html (10)
3-3: Approved: Accessedconfdata from site's configuration usingindex.This change ensures that the configuration data is correctly accessed and used within the template.
4-4: Approved: Addedright-ribbonelement for stable release version.This change adds a visual indicator for the current stable release version.
11-14: Approved: Modified layout structure for stable release information.This change improves the presentation of stable release information by providing more details and a structured layout.
25-30: Approved: Added layout structure for next LTR version.This change adds a visual indicator for the next LTR version.
68-69: Approved: Modified layout structure for packaging information.This change improves the presentation of packaging information by providing a structured layout.
79-80: Approved: Modified layout structure for installer availability information.This change improves the presentation of installer availability information by providing a structured layout.
91-91: Approved: Accessedconfdata from site's configuration for development version usingindex.This change ensures that the configuration data for the development version is correctly accessed and used within the template.
92-92: Approved: Addedright-ribbonelement for development version.This change adds a visual indicator for the current development version.
99-100: Approved: Modified layout structure for active development information.This change improves the presentation of active development information by providing a structured layout.
112-113: Approved: Modified layout structure for feature freeze information.This change improves the presentation of feature freeze information by providing a structured layout.
|
Thanks for the hint @timlinux. Please find below a screenshot of the review.
|
|
I was also looking at the schedule table and have another proposition for the Development Version block. It's about renaming it to "Latest Release" so we will have
|
|
Yeah that looks so nice @Xpirix happy to apply that when you are ready (based on your second screenshot) |
|
Thanks, @timlinux. The changes for the second screenshot are now ready. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- themes/hugo-bulma-blocks-theme/assets/sass/bulma/components/roadmap.sass (3 hunks)
- themes/hugo-bulma-blocks-theme/layouts/shortcodes/roadmap copy.html (1 hunks)
- themes/hugo-bulma-blocks-theme/layouts/shortcodes/roadmap.html (7 hunks)
Files skipped from review as they are similar to previous changes (2)
- themes/hugo-bulma-blocks-theme/assets/sass/bulma/components/roadmap.sass
- themes/hugo-bulma-blocks-theme/layouts/shortcodes/roadmap.html
Additional comments not posted (3)
themes/hugo-bulma-blocks-theme/layouts/shortcodes/roadmap copy.html (3)
194-196: New clock initializations approved.The added initializations for
latest-point-release,freeze, andpackageare consistent with the existing pattern and are correctly implemented.
Line range hint
1-193:
Enhanced release information display structure approved.The restructuring and addition of new elements to display release information provide a clearer and more detailed presentation. The changes are well-organized and logically structured.
Line range hint
148-193:
Clock initialization script approved.The script for initializing clocks is correctly implemented and follows standard practices. It is sourced from an external example (CodePen) and is properly integrated.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- playwright/ci-test/tests/fixtures/roadmap-page.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- playwright/ci-test/tests/fixtures/roadmap-page.ts
|
Isn't it weird/confusing to mix 3.38 development cycle with the master branch? Afaict 3.38 has the same life cycle as 3.34, i.e. only release points with bug fixes after .0, every month. |
|
Thanks @DelazJ What about we add a third box for dev then make these changes:
|
Sounds good to me 👍🏿 @timlinux |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- playwright/ci-test/tests/fixtures/roadmap-page.ts (1 hunks)
- themes/hugo-bulma-blocks-theme/assets/sass/bulma/components/roadmap.sass (4 hunks)
- themes/hugo-bulma-blocks-theme/layouts/shortcodes/roadmap.html (7 hunks)
Files skipped from review due to trivial changes (1)
- playwright/ci-test/tests/fixtures/roadmap-page.ts
Files skipped from review as they are similar to previous changes (1)
- themes/hugo-bulma-blocks-theme/assets/sass/bulma/components/roadmap.sass
Additional comments not posted (9)
themes/hugo-bulma-blocks-theme/layouts/shortcodes/roadmap.html (9)
11-14: LGTM!The changes to display the initial release information for the LTR version are correctly implemented.
68-69: LGTM!The changes to display the packaging information for the LTR version are correctly implemented.
79-80: LGTM!The changes to display the availability of installers for the LTR version are correctly implemented.
99-103: LGTM!The changes to display the initial release information for the latest release are correctly implemented.
178-181: Verify CSS styling for theright-ribbonelement.Ensure that the
right-ribbonelement is styled properly in the CSS file to display the future version correctly.Verification successful
Verified: CSS styling for the
right-ribbonelement is present and appears to be comprehensive.The
right-ribbonelement has multiple CSS rules defined in theroadmap.sassfile, including specific rules for different states such asdevelopment, ensuring proper styling.
themes/hugo-bulma-blocks-theme/assets/sass/bulma/components/roadmap.sassScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the CSS styling for the `right-ribbon` element. # Test: Search for the CSS rules for the `right-ribbon` element. Expect: Proper styling rules. rg --type sass '.right-ribbon'Length of output: 1120
90-93: Verify CSS styling for theright-ribbonelement.Ensure that the
right-ribbonelement is styled properly in the CSS file to display the current version correctly.
2-5: Verify CSS styling for theright-ribbonelement.Ensure that the
right-ribbonelement is styled properly in the CSS file to display the current LTR version correctly.Verification successful
CSS styling for the
right-ribbonelement is properly implemented.The CSS rules for the
.right-ribbonelement are comprehensive and ensure correct styling for displaying the current LTR version.
- The
.right-ribbonelement is positioned and styled appropriately.- Different states (
.stable,.latest,.development) have distinct background colors.- Additional visual effects are applied using
::beforeand::afterpseudo-elements.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the CSS styling for the `right-ribbon` element. # Test: Search for the CSS rules for the `right-ribbon` element. Expect: Proper styling rules. rg --type sass '.right-ribbon'Length of output: 1120
Script:
#!/bin/bash # Extract and display the CSS rules for the `right-ribbon` element from the SASS file. # Display the relevant CSS rules rg --type sass -A 5 '.right-ribbon' themes/hugo-bulma-blocks-theme/assets/sass/bulma/components/roadmap.sassLength of output: 1208
113-118: Verify CSS styling for therm-nextclass.Ensure that the
rm-nextclass is styled properly in the CSS file to highlight the next LR version correctly.Verification successful
The
rm-nextclass is styled properly.The CSS rules for the
rm-nextclass ensure that it has a bold font weight and a distinct color (#ee7913), which should effectively highlight the next LR version.
font-weight: 600color: #ee7913Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the CSS styling for the `rm-next` class. # Test: Search for the CSS rules for the `rm-next` class. Expect: Proper styling rules. rg --type sass '.rm-next'Length of output: 109
Script:
#!/bin/bash # Extract and display the CSS rules for the `rm-next` class from the roadmap.sass file. rg --type sass --context 5 '.rm-next' themes/hugo-bulma-blocks-theme/assets/sass/bulma/components/roadmap.sassLength of output: 321
25-30: Verify CSS styling for therm-currentclass.Ensure that the
rm-currentclass is styled properly in the CSS file to highlight the next LTR version correctly.Verification successful
The
.rm-currentclass is styled properly.The CSS rules for the
.rm-currentclass ensure that the text is bold and colored green, which is appropriate for highlighting the next LTR version.
themes/hugo-bulma-blocks-theme/assets/sass/bulma/components/roadmap.sassScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the CSS styling for the `rm-current` class. # Test: Search for the CSS rules for the `rm-current` class. Expect: Proper styling rules. rg --type sass '.rm-current'Length of output: 115
Script:
#!/bin/bash # Extract and display the CSS rules for the `.rm-current` class from the identified SASS file. rg --type sass -A 5 '.rm-current' themes/hugo-bulma-blocks-theme/assets/sass/bulma/components/roadmap.sassLength of output: 211
|
@Xpirix perhaps center it vertically or reduce the height? |
|
@dimasciput Thanks. I've fixed it. It should be more aligned now. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- themes/hugo-bulma-blocks-theme/layouts/shortcodes/roadmap.html (7 hunks)
Files skipped from review as they are similar to previous changes (1)
- themes/hugo-bulma-blocks-theme/layouts/shortcodes/roadmap.html
|
Beautiful work as always @Xpirix . Thanks for your inputs @DelazJ and @dimasciput |
|
Nice. Thanks to all |
This is the proposed fix for #311
Summary by CodeRabbit
New Features
Style
.right-ribbonelement to indicate different release states:stable,latest, anddevelopment.font-sizeandfont-weightadjustments.