Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the update to the voted rationale. #747

Closed
wants to merge 1 commit into from

Conversation

mbernasocchi
Copy link
Member

@mbernasocchi mbernasocchi commented Apr 8, 2020

This reverts commit cbca8c0.
@pcav the update you did does not reflect the text we voted on. We voted on the text you originally added. commit cbca8c0 adds your personal opinion

@pcav
Copy link
Member

pcav commented Apr 8, 2020

The rationale does reflect what was said in the meeting.

@pcav
Copy link
Member

pcav commented Apr 8, 2020

Now intro separated by rationale, thanks.

@pcav pcav closed this Apr 8, 2020
@mbernasocchi
Copy link
Member Author

mbernasocchi commented Apr 8, 2020

The rationale does reflect what was said in the meeting.

nope, it reflected what you said, not what was said.

Now intro separated by rationale, thanks.

Thanks bit better now, even though you now added something that was not there in the original plan

@DelazJ DelazJ deleted the revert_wrong_vote_text branch April 27, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants