Fix crash on value relation multi-column

Fix #54164
qgis · Oct 10, 2023 · 03af4e3 · 03af4e3
1 parent 0a4796c
commit 03af4e3
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/gui/editorwidgets/qgsvaluerelationwidgetwrapper.cpp b/src/gui/editorwidgets/qgsvaluerelationwidgetwrapper.cpp
@@ -157,11 +157,18 @@ void QgsFilteredTableWidget::populate( QgsValueRelationFieldFormatter::ValueRela
 
 void QgsFilteredTableWidget::setIndeterminateState()
 {
-  for ( int j = 0; j < mTableWidget->rowCount(); j++ )
+  for ( int rowIndex = 0; rowIndex < mTableWidget->rowCount(); rowIndex++ )
   {
-    for ( int i = 0; i < mColumnCount; ++i )
+    for ( int columnIndex = 0; columnIndex < mColumnCount; ++columnIndex )
     {
-      whileBlocking( mTableWidget )->item( j, i )->setCheckState( Qt::PartiallyChecked );
+      if ( item( rowIndex, columnIndex ) )
+      {
+        whileBlocking( mTableWidget )->item( rowIndex, columnIndex )->setCheckState( Qt::PartiallyChecked );
+      }
+      else
+      {
+        break;
+      }
     }
   }
 }