Fix crash with "add selected layers" from browser (fix #14223)

nyalldawson · nyalldawson · commit 0796df00fb91 · 2016-02-04T16:20:30.000+11:00
diff --git a/src/app/qgsbrowserdockwidget.cpp b/src/app/qgsbrowserdockwidget.cpp
@@ -577,9 +577,9 @@ void QgsBrowserDockWidget::addSelectedLayers()
   qSort( list );
 
   // If any of the layer items are QGIS we just open and exit the loop
-  for ( int i = 0; i <= list.size(); i++ )
+  Q_FOREACH ( const QModelIndex& index, list )
   {
-    QgsDataItem *item = mModel->dataItem( mProxyModel->mapToSource( list[i] ) );
+    QgsDataItem *item = mModel->dataItem( mProxyModel->mapToSource( index ) );
     if ( item && item->type() == QgsDataItem::Project )
     {
       QgsProjectItem *projectItem = qobject_cast<QgsProjectItem*>( item );

Original file line number	Diff line number	Diff line change
`@@ -577,9 +577,9 @@ void QgsBrowserDockWidget::addSelectedLayers()`
`577`	`577`	`qSort( list );`
`578`	`578`
`579`	`579`	`// If any of the layer items are QGIS we just open and exit the loop`
`580`		`- for ( int i = 0; i <= list.size(); i++ )`
	`580`	`+ Q_FOREACH ( const QModelIndex& index, list )`
`581`	`581`	`{`
`582`		`- QgsDataItem *item = mModel->dataItem( mProxyModel->mapToSource( list[i] ) );`
	`582`	`+ QgsDataItem *item = mModel->dataItem( mProxyModel->mapToSource( index ) );`
`583`	`583`	`if ( item && item->type() == QgsDataItem::Project )`
`584`	`584`	`{`
`585`	`585`	`QgsProjectItem projectItem = qobject_cast<QgsProjectItem>( item );`