-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add macOS 1024x1024 icon for dock, app switcher, etc., rendering
[ci skip]
- Loading branch information
Showing
2 changed files
with
5 additions
and
0 deletions.
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35edc18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could other platforms benefit from this too?
35edc18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly. I did not test.
I only noticed the issue on macOS, and that it could be resolved by setting the icon with
QApplication:: setWindowIcon()
. However, the Qt doc on the app icon is not clear on whether this helps with similar app representations on other platforms, e.g. 'dock,' app switcher, etc. It seems a desktop entry is appropriate on common Linux platforms, and the .ico approach is right for Windows.Would be worth testing a higher resolution
QApplication windowIcon
on those platforms, in case it does help. Certainly something bigger than the paltry 60x60 should be the standard gong forward in any event... like 256x256 or 512x512. Again, this is the app (top level window) icon, which differs from the desktop icon, and higher resolutions may not benefit other platforms than macOS.@elpaso, I know you are running a hidpi monitor. Do you have time to test out some higher res icons on KDE?