Skip to content

Commit

Permalink
Update Datasources2Vrt.py
Browse files Browse the repository at this point in the history
Naming more consistent with other tools.
  • Loading branch information
pcav committed May 24, 2015
1 parent 2ff6f72 commit 3ecf6e6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions python/plugins/processing/algs/qgis/Datasources2Vrt.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def defineCharacteristics(self):
"""

# The name that the user will see in the toolbox
self.name = 'Merge datasources in VRT'
self.name = 'Build virtual vector'

# The branch of the toolbox under which the algorithm will appear
self.group = 'Vector general tools'
Expand All @@ -78,9 +78,9 @@ def defineCharacteristics(self):

# We add outputs
self.addOutput(OutputFile(self.OUTPUT_VRT_FILE,
self.tr('Output vrt filename')))
self.tr('Virtual vector')))
self.addOutput(OutputString(self.OUTPUT_VRT_STRING,
self.tr('Output vrt string')))
self.tr('Virtual string')))


def processAlgorithm(self, progress):
Expand Down

2 comments on commit 3ecf6e6

@luipir
Copy link
Contributor

@luipir luipir commented on 3ecf6e6 May 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree, it's not the scope of the command. Merging different datasources is not simply creating a vrt. With this name, a user can be confused and erroneously merge datasources when he don't wont.

commit would be reverted of changed in a different name that avoid confusion.

@pcav
Copy link
Member Author

@pcav pcav commented on 3ecf6e6 May 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please suggest a better naming. "datasoruces" and "VRT" are ununderstandable to normal users.
Thanks.

Please sign in to comment.