[processing] Regenerate primary key when running the dissolve algorit…

…hm (fixes #55587)
qgis · Jan 24, 2024 · c3738ac · c3738ac
1 parent b851e7c
commit c3738ac
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/python/plugins/processing/tests/testdata/expected/dissolve_pol.gpkg b/python/plugins/processing/tests/testdata/expected/dissolve_pol.gpkg
diff --git a/python/plugins/processing/tests/testdata/qgis_algorithm_tests1.yaml b/python/plugins/processing/tests/testdata/qgis_algorithm_tests1.yaml
@@ -899,6 +899,21 @@ tests:
           geometry:
             normalize: True
 
+  - algorithm: native:dissolve
+    name: Dissolve separate disjoint with geopackage input and output 
+    params:
+      INPUT:
+        name: custom/pol.gpkg|layername=pol1
+        type: vector
+      SEPARATE_DISJOINT: true
+    results:
+      OUTPUT:
+        name: expected/dissolve_pol.gpkg
+        type: vector
+        compare:
+          geometry:
+            normalize: True
+
   - algorithm: native:dissolve
     name: Dissolve separate disjoint with classes
     params:

diff --git a/src/analysis/processing/qgsalgorithmdissolve.cpp b/src/analysis/processing/qgsalgorithmdissolve.cpp
@@ -31,7 +31,7 @@ QVariantMap QgsCollectorAlgorithm::processCollection( const QVariantMap &paramet
     throw QgsProcessingException( invalidSourceError( parameters, QStringLiteral( "INPUT" ) ) );
 
   QString dest;
-  std::unique_ptr< QgsFeatureSink > sink( parameterAsSink( parameters, QStringLiteral( "OUTPUT" ), context, dest, source->fields(), QgsWkbTypes::multiType( source->wkbType() ), source->sourceCrs() ) );
+  std::unique_ptr< QgsFeatureSink > sink( parameterAsSink( parameters, QStringLiteral( "OUTPUT" ), context, dest, source->fields(), QgsWkbTypes::multiType( source->wkbType() ), source->sourceCrs(), QgsFeatureSink::RegeneratePrimaryKey ) );
 
   if ( !sink )
     throw QgsProcessingException( invalidSinkError( parameters, QStringLiteral( "OUTPUT" ) ) );