Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Projection Definition #11206

Closed
qgib opened this issue Jul 8, 2008 · 3 comments
Closed

Custom Projection Definition #11206

qgib opened this issue Jul 8, 2008 · 3 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Projections/Transformations Related to coordinate reference systems or coordinate transformation

Comments

@qgib
Copy link
Contributor

qgib commented Jul 8, 2008

Author Name: Alessandro Frigeri (Alessandro Frigeri)
Original Redmine Issue: 1146

Redmine category:projection_support
Assignee: nobody -


Hello,

while adding a projection definition in the Custom Projection Definition dialog, if I pass 'a' and 'b' parameters instead the 'ellps' I got the error message: "This proj4 ellps definition is not valid. Please add a valid ellps clause before pressing save".
Even adding the ellipsoid name (e.g. foo) and relative parameters to qgis.db and passing +ellps=foo does not work, as qgis rises up: "This proj4 definition is not valid. Please correct before saving".

To fix this beaviour temporarily I commented out lines 775-780 of src/app/qgscustomprojectiondialog.cpp ( conditional statement on myEllipsoidAcronym.isNull() ); in this way, the projection definition is accepted also with 'a' and 'b' parameters and the reprojection on the fly works as expected (I've checked coordinates with proj using the same proj4 definition on the command line).

Best regards,

Alessandro Frigeri

@qgib
Copy link
Contributor Author

qgib commented Jul 10, 2008

Author Name: Tim Sutton (Tim Sutton)


Hi

Ok so I agree its probably best to comment out the check for now since there are a number of non ellps+ ways to specify the ellipsoid. In the future we could implement more sophisticated checks to try to validate the various permutations, but for now the fact that the proj string in its entirety is checked in the code that follows this block should be sufficient. Here is the comment I placed in the code.

/** I am commenting this check out for now because of ticket #11206
*** In 1.0.0 we should consider doing more sophisticated checks or just
*** removing this commented block entirely. It is possible to set the
*** parameters for the earths figure in ways other than using ellps (which
*** is a convenience function in proj). For example the radius and flattenning
*** can be specified and various other parameter permutations. See the proj
*** manual section entitled 'Specifying the Earths Figure' for more details.
*** Tim Sutton */

Many thanks

Regards

Tim


  • resolution was changed from to fixed
  • status_id was changed from Open to Closed

@qgib
Copy link
Contributor Author

qgib commented Jul 10, 2008

Author Name: Tim Sutton (Tim Sutton)


Fix was applied as ee275ab (SVN r8749).

@qgib
Copy link
Contributor Author

qgib commented Aug 21, 2009

Author Name: Anónimo (Anónimo)


Milestone Version 0.11.0 deleted

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Projections/Transformations Related to coordinate reference systems or coordinate transformation labels May 24, 2019
@qgib qgib closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Projections/Transformations Related to coordinate reference systems or coordinate transformation
Projects
None yet
Development

No branches or pull requests

1 participant