-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Console doens't allow to write non-ascii chars #15752
Milestone
Comments
JamesShaeffer
pushed a commit
to JamesShaeffer/QGIS
that referenced
this issue
Nov 20, 2019
Cuts render time by ~60%. Fix qgis#15752. (cherry-picked from 5798a82)
JamesShaeffer
pushed a commit
to JamesShaeffer/QGIS
that referenced
this issue
Nov 20, 2019
Make nCoordinates virtual, and provide shortcuts for some geometry types. The base method which calls coordinateSequence() is quite slow in certain circumstances. Speeds up rendering point layers by ~25%, also likely to speed up lots of geometry heavy operations throughout QGIS Refs qgis#15752 (cherry-picked from 49432a8)
JamesShaeffer
pushed a commit
to JamesShaeffer/QGIS
that referenced
this issue
Nov 20, 2019
...where appropriate (ie, read-only, non user set variables). It's much faster as it doesn't need to check whether the variable already exists. Results in ~10% improvement in rendering speed. Refs qgis#15752. (cherry-picked from 8589788)
JamesShaeffer
pushed a commit
to JamesShaeffer/QGIS
that referenced
this issue
Nov 20, 2019
...and refine validity test from 57dc3c7 Using Filter is more performant since it does a bounding box only check when an appropriate spatial index is available. This matches the behavior with other providers, where the provider filter only does a bounding box check and callers must perform the actual intersection check if required. While Filter also avoids SQL server closing the iterator upon encountering invalid geometries, we can't rely on this because SQL server will transparently fall back to STIntersects if it decides there's no suitable spatial indexes available, and then throw an exception on invalid geometries. So we still require the STISValid check when using Filter. The extent calculation from 57dc3c7 has been refined to avoid the very expensive STMakeValid call. Instead we use a (ugly!) workaround to skip invalid geometries using STIsValid only inside the min/max x/y aggregates. Note that we can't just dump a WHERE STIsValid clause in to the statement because SQL server still throws the exception. Gotta love it! Fix qgis#15752, qgis#10947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Author Name: Giuseppe Sucameli (@brushtyler)
Original Redmine Issue: 6548
Affected QGIS version: master
Redmine category:python_plugins
Assignee: Salvatore Larosa
The title says all.
The text was updated successfully, but these errors were encountered: