-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Merge attribute of selected features" tools set ignored attributes to NULL #21292
Comments
Author Name: Jürgen Fischer (@jef-n)
|
Author Name: Jukka Rahkonen (Jukka Rahkonen) What do you suggest? If you merge features A and B which have an attribute X with values In case a) it feels natural to set X=1 also for the new merged feature. How about case b), would you like to get concatenated string X=1,2? What if the datatype of the column is numeric, would it be 1+2 then, and how should we deal with Boolean values? |
Author Name: Mathieu Bossaert (Mathieu Bossaert) Maybe with do not talk about the same tool... It is not a feature aggregation, features are not merged : So if all selected features are conserved with this tool, I think it could be logical and usefull to be able to conserve the initial value of that attribute. |
Author Name: Jukka Rahkonen (Jukka Rahkonen) Right, we did not talk about the same tool. I agree that there should be an option to leave the ignored attributes to their native value instead of setting them to NULL. It seems that the UI of this tool is a copy of the Merge features tool which lets user to select which value to give for the merged feature, including concatenate for strings and min/max/median/sum/mean for numbers. If features are physically merged with the "Merge selected features" tool it is impossible to preserve the native attributes but there should be one more option for the "Merge attribute of selected features" tool: Keep native. |
Author Name: Nyall Dawson (@nyalldawson) Fixed in changeset "0bda18b6e04105d52cfe6f54792de2f2e2b4a925".
|
Author Name: Harrissou Santanna (@DelazJ) I suspect it's introduced by this commit but I may be wrong. sorry then :(
|
Author Name: Nyall Dawson (@nyalldawson)
This was an intentional change. I think for something like this which has the potential to lead to overwriting data that users should have to intentionally select the fields they want to replace rather than defaulting to replacing everything. It's also a better workflow for tables with many columns - it's not often you'd want to replace EVERYTHING in the features, so starting with all skipped and leaving it to the user to manually select the columns to merge is a better approach.
|
Author Name: Harrissou Santanna (@DelazJ) Sorry, you're right. I mixed up "Skip" and "NULL" values. |
Author Name: Mathieu Bossaert (Mathieu Bossaert) Thanks a lot for that work ! |
(cherry picked from commit 8851328)
Author Name: Mathieu Bossaert (Mathieu Bossaert)
Original Redmine Issue: 13231
Affected QGIS version: 2.8.2
Redmine category:vectors
Assignee: Nyall Dawson
I don't know if its a bug or a feature request because I did not use that tool before (but I try it on both 2.8 and 2.10 versions for Win 7).
Anyway when I choose an attribute to be ignored during the merge operation (for example the id), it is set to NULL.
The text was updated successfully, but these errors were encountered: