Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB Manager Versioning: _current view lacks primary key #25888

Closed
qgib opened this issue Jan 29, 2018 · 6 comments · Fixed by #30045

Comments

@qgib
Copy link
Contributor

commented Jan 29, 2018

Author Name: Paolo Cavallini (@pcav)
Original Redmine Issue: 17992
Affected QGIS version: 3.3(master)
Redmine category:db_manager


The Versioning / Change logging automatically creates a view with the current elements. Unfortunately, in the view it is not included the id_hist, but only the id, which can be duplicated, e.g. in case of a split polygon.
As a consequence, the view cannot be loaded.
I suggest to simply add id_hist to the view.
The fix can be easily backported to 2.18.

@qgib

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2018

Author Name: Paolo Cavallini (@pcav)


See also #22026

@qgib

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2018

Author Name: Giovanni Manghi (@gioman)


PLEASE UPDATE THE AFFECTED VERSION!


  • version was changed from master to 3.0.0
@qgib

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2018

Author Name: Loïc BARTOLETTI (@lbartoletti)


Should be closed? Now you can define the name of PK (and others)

@qgib

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2018

Author Name: Paolo Cavallini (@pcav)


AFAICT this is still valid: in the view simply there is not a PK, it's not a matter of its name.

@qgib

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2018

Author Name: Giovanni Manghi (@gioman)


Paolo Cavallini wrote:

AFAICT this is still valid: in the view simply there is not a PK, it's not a matter of its name.

checked on master? if yes change the affected version.

@qgib

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2018

Author Name: Paolo Cavallini (@pcav)


Confirmed


  • version was changed from 3.0.0 to 3.3(master)
alexbruy added a commit to alexbruy/QGIS that referenced this issue May 31, 2019
alexbruy added a commit that referenced this issue Jun 5, 2019
Merge pull request #30045 from alexbruy/dbmanager-versioning
[dbmanager] add primary key to the view created by versioning plugin (fix #25888)
backporting bot pushed a commit that referenced this issue Jun 5, 2019
alexbruy added a commit that referenced this issue Jun 22, 2019
Merge pull request #30090 from qgis/backport-30045-to-release-3_4
[Backport release-3_4] [dbmanager] add primary key to the view created by versioning plugin (fix #25888)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.