Edit features in place - fix geometries not working

[qgib]

Author Name: Andy Whyte (Andy Whyte)
Original Redmine Issue: 20812
Affected QGIS version: 3.5(master)
Redmine category:processing/core
Assignee: Alessandro Pasotti

---

When using the edit features in place function with fix geometries it does not seem to work.

I tested on the same data set with and without the "in place" function and it worked without.

Please see Gif

---

• Edit in place - fix geometries.gif (Andy Whyte)
• NHS_CCG_Boundaries.shp (Andy Whyte)
• Test project.qgz (Andy Whyte)
• NHS_CCG_Boundaries.prj (Andy Whyte)
• NHS_CCG_Boundaries.dbf (Andy Whyte)
• NHS_CCG_Boundaries.shx (Andy Whyte)

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

• assigned_to_id was configured as Alessandro Pasotti

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Would you please add a test project and data? That would speed up the bug fixing process a lot.

[qgib]

Author Name: Andy Whyte (Andy Whyte)

---

• 13982 was configured as NHS_CCG_Boundaries.shp
• 13983 was configured as Test project.qgz

---

• NHS_CCG_Boundaries.shp (Andy Whyte)
• Test project.qgz (Andy Whyte)

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Thanks for attaching data: I'll have a look ASAP.

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

.SHP is not enough for shapefile data, you need to attach all the other files.

[qgib]

Author Name: Andy Whyte (Andy Whyte)

---

Apologies

---

• 14013 was configured as NHS_CCG_Boundaries.dbf
• 14012 was configured as NHS_CCG_Boundaries.prj

---

• NHS_CCG_Boundaries.dbf (Andy Whyte)
• NHS_CCG_Boundaries.prj (Andy Whyte)

[qgib]

Author Name: Andy Whyte (Andy Whyte)

---

• 14014 was configured as NHS_CCG_Boundaries.shx

---

• NHS_CCG_Boundaries.shx (Andy Whyte)

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Your problem is probably caused by a processing setting, please check under

Settings -> Processing -> General -> Invalid features filtering => Do not filter (better performances)

Obviously that is the only value that makes sense for this algorithm or the invalid features will not even get passed in.

---

• status_id was changed from Open to Feedback

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

PR: #8730

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

• version was changed from 3.4.2 to 3.5(master)
• operating_system was changed from Windows 10 to

[qgib]

Author Name: Andy Whyte (Andy Whyte)

---

Thanks for your help

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Thank you for filing this issue, it was indeed a bug: the setting should be ignored for those algorithms that fix broken geometries.

---

• status_id was changed from Feedback to In Progress

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Applied in changeset f4d7506.

---

• status_id was changed from In Progress to Closed
• done_ratio was changed from 0 to 100