Processing in-place do not check validity when fixing geometries

[elpaso]

Fixes #20812

[m-kuhn]

Could alg.sourceFlags() be used instead of the part labeled with "ugly hack"?

[elpaso]

@m-kuhn yes, that's probably much less "ugly" ;) I'l l see if it can be used in this context.

[elpaso]

@m-kuhn it worked! Thanks.

[m-kuhn]

Nice.
I thought only feature based algorithms can be used in place, is that not true?

[elpaso]

No: all algorithms can be used for in-place, there are separate code paths for the two types.

[m-kuhn]

How does it decide which input to take in such cases? What I'm wondering if there's a more portable solution that works for any algorithm.

[elpaso]

I'm not sure about what you mean but I don't see a way to set the context geom flags for non-feature-based (unless the sourceFlags() is moved to the base class), have a look to: https://github.com/qgis/QGIS/blob/master/python/plugins/processing/gui/AlgorithmExecutor.py#L149 for feature based and a few lines below for the other case:

https://github.com/qgis/QGIS/blob/master/python/plugins/processing/gui/AlgorithmExecutor.py#L194

[m-kuhn]

Oh, I didn't realize that the code paths are so different. Looks like that's taken care of with https://github.com/qgis/QGIS/blob/master/python/plugins/processing/gui/AlgorithmExecutor.py#L198 for the other case (in which it chooses the parameters called INPUT and OUTPUT if I read this correctly).

I think it would be nice to also have this flag on QgsProcessingParameterFeatureSource, but that's a different story.

Looks good to me now.