Full row conditional formatting formats wrong full rows #34122
Assignees
Labels
Comments
uclaros
added
the
Bug
|
Confirmed also here. This is bad as it could lead to wrong and potentially dangerous decisions made by looking at color codes... |
|
FYI @NathanW2 |
|
Ouch. yeah, that isn't good. I don't recall that being the case when I
built it but it has been a while.
…On Thu, Jan 30, 2020 at 10:03 PM Luigi Pirelli ***@***.***> wrote:
FYI @NathanW2 <https://github.com/NathanW2>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34122?email_source=notifications&email_token=AAC5FXEQNAGIQCH6ICPDRETRAK6XNA5CNFSM4KNJVVUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKKXTRQ#issuecomment-580221382>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC5FXA5YVCVJ47QSNJEBATRAK6XNANCNFSM4KNJVVUA>
.
|
|
It's easy to miss it since everything works perfectly until you need to refresh. |
elpaso
added a commit
to elpaso/QGIS
that referenced
this issue
Feb 5, 2020
Fixes qgis#34122 The original implementation was storing the styles in an hash keyed by the row number from the model index, but that one changes when the table is reloaded. By using feature id as a key instead, the style association with the feature is maintained through sort/reload operations.
nyalldawson
pushed a commit
that referenced
this issue
Feb 5, 2020
Fixes #34122 The original implementation was storing the styles in an hash keyed by the row number from the model index, but that one changes when the table is reloaded. By using feature id as a key instead, the style association with the feature is maintained through sort/reload operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In the attribute table, full row conditional formatting formats wrong rows when the attribute table is sorted and then refreshed. Some rows that should be formatted are not, and some that should not be, they are.
How to Reproduce
Open the attribute table from the attached project, sort by some column and hit refresh.
The highlight condition is
"top" % 10 = 0 and "right" % 10 = 0and the rows that should be highlighted are the ones with"shouldbegreen" = 1.QGIS and OS versions
Happens on qgis master, but also on older builds like 3.8, both linux and windows. Haven't tested others.
Additional context
Could be the same bug as #28352, though no edits are required to reproduce it so I opened a new one.
Here is a sample project and dataset. I added lots of rows so it's easier for the bug to appear.
bug.zip
The text was updated successfully, but these errors were encountered: